Re: [PATCH] sdhci: Specific quirk vor VIA SDHCI controller in VX855ES

[Pierre Ossman <pierre@ossman.eu>]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

On Sat, 20 Jun 2009 00:28:28 +0200
Harald Welte <HaraldWelte@viatech.com> wrote:

> Hi!
> 
> On Fri, Jun 19, 2009 at 09:33:14PM +0200, Pierre Ossman wrote:
> 
> > Does this block have a name? Something nicer than 0x95d0 in the id list
> > would be nice.
> 
> Unfortunately no.  We really have a big mess with those integrated chipsets
> that have something like 15 PCI devices inside one component.  We cannot call
> all of them 'VX855'. or 'VX800', as that would clash.  Naming things
> 'PCI_DEVICE_VIA_VX800_SDHCI' is also not really correct, since the same
> block appearas in other integrated chipsets, too.
> 
> As for VIA's documentation, every block is called something like D13F3 (pci
> device 13 function 3), which doesn't really sound all that much better than
> just putting a 0x95d0 there.
> 
> To make things even furter complicated, some VIA Docs refer to the SDHCI
> controller as 'SDIO controller' and the via-sdmmc as 'SD card controller'...
> 

Sounds like you guys need an official code name department. :)

I've queued up the patch.

-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]