From: David Miller <davem@davemloft.net>
To: bzolnier@gmail.com
Cc: elendil@planet.nl, sparclinux@vger.kernel.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: cmd64x: irq 14: nobody cared - system is dreadfully slow
Date: Tue, 23 Jun 2009 16:04:40 -0700 (PDT) [thread overview]
Message-ID: <20090623.160440.243068553.davem@davemloft.net> (raw)
In-Reply-To: <200906231813.09570.bzolnier@gmail.com>
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Date: Tue, 23 Jun 2009 18:13:08 +0200
> On Tuesday 23 June 2009 16:58:54 Frans Pop wrote:
>> So it seems to me that in 2.6.26 something was broken in the way these ID
>> fields were handled, at least in this check. This is now fixed (possibly
>
> Great debugging work, thanks!
Indeed, thanks for all of that work Frans!
>> by the changes around 5b90e990..48fb2688) and *that* causes the
>> regression. Note that the hard disks are also affected.
>
> I see it now -- in commit c419993 ("ide-iops: only clear DMA words
> on setting DMA mode") we fixed a bug in ide_config_drive_speed()..
>
> [ It was a real bug resulting in incorrect data being passed to
> the user-space through HDIO_GET_IDENTITY ioctl ('hdparm -i'). ]
Given all of this I also agree that we should apply Bart's patch to
remove the debugging check altogether, and I will thus do that right
now.
next prev parent reply other threads:[~2009-06-23 23:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200906211446.38598.elendil@planet.nl>
[not found] ` <20090621.224510.96380426.davem@davemloft.net>
[not found] ` <200906220843.14337.elendil@planet.nl>
2009-06-22 11:21 ` Bartlomiej Zolnierkiewicz
2009-06-22 14:04 ` Frans Pop
2009-06-22 14:39 ` Bartlomiej Zolnierkiewicz
2009-06-22 15:16 ` Frans Pop
2009-06-22 17:38 ` Bartlomiej Zolnierkiewicz
2009-06-22 19:01 ` Frans Pop
2009-06-22 21:35 ` Bartlomiej Zolnierkiewicz
2009-06-23 7:51 ` [PATCH] ide-cd: Improve "weird block size" error message Frans Pop
2009-06-23 7:57 ` Borislav Petkov
2009-06-23 8:02 ` Borislav Petkov
2009-06-23 23:03 ` David Miller
2009-06-23 8:20 ` Frans Pop
2009-06-23 10:59 ` David Miller
2009-06-23 11:13 ` Frans Pop
2009-06-23 11:18 ` David Miller
2009-06-23 21:30 ` Frans Pop
2009-06-23 23:01 ` David Miller
2009-06-29 11:19 ` Jan Engelhardt
2009-06-23 10:15 ` cmd64x: irq 14: nobody cared - system is dreadfully slow David Miller
2009-06-23 14:58 ` Frans Pop
2009-06-23 16:13 ` Bartlomiej Zolnierkiewicz
2009-06-23 23:04 ` David Miller [this message]
2009-06-23 10:47 ` David Miller
2009-06-23 10:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623.160440.243068553.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bzolnier@gmail.com \
--cc=elendil@planet.nl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®