From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760658AbZFWXYO (ORCPT ); Tue, 23 Jun 2009 19:24:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758273AbZFWXX6 (ORCPT ); Tue, 23 Jun 2009 19:23:58 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:38628 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757540AbZFWXX6 (ORCPT ); Tue, 23 Jun 2009 19:23:58 -0400 Date: Tue, 23 Jun 2009 16:24:02 -0700 (PDT) Message-Id: <20090623.162402.125952364.davem@davemloft.net> To: bzolnier@gmail.com Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 6/6] ide: improve handling of Power Management requests From: David Miller In-Reply-To: <200906232335.57161.bzolnier@gmail.com> References: <200906232335.57161.bzolnier@gmail.com> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartlomiej Zolnierkiewicz Date: Tue, 23 Jun 2009 23:35:56 +0200 > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] ide: improve handling of Power Management requests > > Make hwif->rq point to PM request during PM sequence and do not allow > any other types of requests to slip in (the old comment was never correct > as there should be no such requests generated during PM sequence). > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > This was tested in the past (with an additional testing from Borislav) > however there were block layer changes in the meantime so you may want > to give it some more testing time just to be sure. In looking at this change, it occurs to me that this queue blocking facility could also be used to solve the user SET_XFER race. Couldn't it?