From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1757643AbZFWXjW@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757643AbZFWXjW (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Jun 2009 19:39:22 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755155AbZFWXjO
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 23 Jun 2009 19:39:14 -0400
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:59483
	"EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753648AbZFWXjN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Jun 2009 19:39:13 -0400
Date: Tue, 23 Jun 2009 16:39:17 -0700 (PDT)
Message-Id: <20090623.163917.202270116.davem@davemloft.net>
To: joe@perches.com
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
       linux-kernel@vger.kernel.org, petkovbb@gmail.com, htejun@gmail.com
Subject: Re: [patch 3/6] ide: always kill the whole request on error
From: David Miller <davem@davemloft.net>
In-Reply-To: <1245800274.29098.75.camel@Joe-Laptop.home>
References: <200906232327.27610.bzolnier@gmail.com>
	<20090623.161904.177489795.davem@davemloft.net>
	<1245800274.29098.75.camel@Joe-Laptop.home>
X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Joe Perches <joe@perches.com>
Date: Tue, 23 Jun 2009 16:37:54 -0700

> On Tue, 2009-06-23 at 16:19 -0700, David Miller wrote:
>> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>> Date: Tue, 23 Jun 2009 23:27:27 +0200
>> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>> > Subject: [PATCH] ide: always kill the whole request on error
>> > --- a/drivers/ide/ide-eh.c
>> > +++ b/drivers/ide/ide-eh.c
>> > @@ -149,7 +149,7 @@ static inline void ide_complete_drive_re
>> >  	if (rq && blk_special_request(rq) && rq->cmd[0] == REQ_DRIVE_RESET) {
>> >  		if (err <= 0 && rq->errors == 0)
>> >  			rq->errors = -EIO;
>> > -		ide_complete_rq(drive, err ? err : 0, ide_rq_bytes(rq));
>> > +		ide_complete_rq(drive, err ? err : 0, blk_rq_bytes(rq));
> 
> Doesn't that "err ? err : 0" look odd?
> Why not just err?

These functions are full of surprises :-)

Yes, plain 'err' should be absolutely equivalent to what's
there right now.