From: David Miller <davem@davemloft.net>
To: alan@lxorguk.ukuu.org.uk
Cc: bzolnier@gmail.com, elendil@planet.nl, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cs5520: add missing IRQ setup for the second port
Date: Tue, 23 Jun 2009 16:44:29 -0700 (PDT) [thread overview]
Message-ID: <20090623.164429.179899088.davem@davemloft.net> (raw)
In-Reply-To: <20090623163324.715421f5@lxorguk.ukuu.org.uk>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Tue, 23 Jun 2009 16:33:24 +0100
>> > The cs5520 isn't a standard IDE controller in the first place and doesn't
>> > have two channels anyway. It's special as it uses non standard bar
>>
>> Please note that both cs5520.c / pata_cs5520.c assume that the controller
>> has two ports (please verify whether they need some fixing, thanks)..
>
> It can it turns out have two if the relevant external logic is present.
Ok, so previously the code would set both port IRQs to 14. But now
only the first port IRQ gets initialized to 14, any subsequent port
has it's IRQ left uninitiailized.
What should we do? I guess "do nothing and wait until we see a bug
report from an actual user" is a valid response...
next prev parent reply other threads:[~2009-06-23 23:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 11:48 Bartlomiej Zolnierkiewicz
2009-06-22 23:31 ` David Miller
2009-06-22 23:58 ` Frans Pop
2009-06-23 8:42 ` Alan Cox
2009-06-23 9:59 ` Bartlomiej Zolnierkiewicz
2009-06-23 15:33 ` Alan Cox
2009-06-23 23:44 ` David Miller [this message]
2009-06-24 9:22 ` Alan Cox
2009-06-24 9:36 ` David Miller
2009-06-23 0:30 ` Bartlomiej Zolnierkiewicz
2009-06-23 1:05 ` Bartlomiej Zolnierkiewicz
2009-06-23 4:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623.164429.179899088.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=elendil@planet.nl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®