From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754372AbZFWTkk@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754372AbZFWTkk (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Jun 2009 15:40:40 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752674AbZFWTkc
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 23 Jun 2009 15:40:32 -0400
Received: from mx3.mail.elte.hu ([157.181.1.138]:33006 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752411AbZFWTkc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Jun 2009 15:40:32 -0400
Date: Tue, 23 Jun 2009 21:40:09 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
       lkml <linux-kernel@vger.kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       Jim Keniston <jkenisto@us.ibm.com>,
       Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
       Christoph Hellwig <hch@infradead.org>,
       Steven Rostedt <rostedt@goodmis.org>,
       Anders Kaseorg <andersk@ksplice.com>, Tim Abbott <tabbott@ksplice.com>,
       systemtap <systemtap@sources.redhat.com>,
       DLE <dle-develop@lists.sourceforge.net>
Subject: Re: [RFC][ PATCH -tip v2 0/7] kprobes: Kprobes jump optimization
	support
Message-ID: <20090623194009.GA8777@elte.hu>
References: <20090622212255.5384.53732.stgit@localhost.localdomain> <20090623114252.GB9497@elte.hu> <4A40E153.9030704@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A40E153.9030704@redhat.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-ELTE-SpamScore: -1.5
X-ELTE-SpamLevel: 
X-ELTE-SpamCheck: no
X-ELTE-SpamVersion: ELTE 2.0 
X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5
	-1.5 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Masami Hiramatsu <mhiramat@redhat.com> wrote:

> Ingo Molnar wrote:
> > * Masami Hiramatsu <mhiramat@redhat.com> wrote:
> > 
> >> o Usage
> >>  Set CONFIG_OPTPROBES=y when building a kernel, then all *probes will be
> >> optimized if possible.
> > 
> > Should be default-y if KPROBES is enabled. I.e. we really only want 
> > to disable it to debug potential issues.
> 
> Sure, thanks!

Plus i'd suggest a runtime control (a sysctl) as well - if it's not 
too intrusive. Since this is an optional speedup feature, distros 
can have this enabled and if there's some problem with it then it 
can still be disabled in sysctl.conf, without having to rebuild the 
kernel.

	Ingo