mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andi@firstfloor.org
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: NMI watchdog + NOHZ question
Date: Wed, 24 Jun 2009 00:08:11 -0700 (PDT)	[thread overview]
Message-ID: <20090624.000811.118222188.davem@davemloft.net> (raw)
In-Reply-To: <20090624070315.GH6760@one.firstfloor.org>

From: Andi Kleen <andi@firstfloor.org>
Date: Wed, 24 Jun 2009 09:03:15 +0200

>> I'm not exactly sure what to do about this.
> 
> Ack the timer interrupt earlier (and also give it a high priority?)

It has a higher priority, but all interrupts get re-enabled right
before we process software interrupts.  So the flood of qla2xxx
interrupts can come in before we can run the timer softirq and
thus schedule the next timer interrupt.

> That could be still problematic if you have non nestabled irq stacks
> (haven't checked if sparc has that or not), 
> potentially you might need to run the softirq on the process stack.

IRQ stacks on sparc64 work identically to how they do on x86.

I have some more theories about this, in that I always see the
NMI watchdog message with a PC right in the section of CPU idle
where NOHZ is enabled.

On these cpus there is no support yielding, so on them I just
touch the NMI watchdog in the loop waiting for need_resched()
to become true.

But if we get the qla2xxx interrupt storm during that loop, it's
pretty easy to not touch the NMI watchdog in time.

  reply	other threads:[~2009-06-24  7:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-22  7:27 David Miller
2009-06-22  8:18 ` Andi Kleen
2009-06-22  9:27   ` David Miller
2009-06-24  0:17     ` David Miller
2009-06-24  7:03       ` Andi Kleen
2009-06-24  7:08         ` David Miller [this message]
2009-06-24  7:15           ` Andi Kleen
2009-06-24  7:17             ` David Miller
2009-06-24  7:53               ` Andi Kleen
2009-06-24  8:51                 ` David Miller
2009-06-24  9:44                 ` David Miller
2009-06-24 10:23                   ` Andi Kleen
2009-06-24 10:32                     ` David Miller
2009-06-24 10:52                       ` Andi Kleen
2009-06-24 10:59                         ` David Miller
2009-06-24 11:10                           ` Andi Kleen
2009-09-03  9:36       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090624.000811.118222188.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®