From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
linux-usb@vger.kernel.org, oliver@neukum.name
Subject: Re: [PATCH 2/3] Fix oops when closing ACM tty device right after open has failed.
Date: Wed, 24 Jun 2009 18:35:23 -0300 [thread overview]
Message-ID: <20090624213522.GH5299@vespa.holoscopio.com> (raw)
In-Reply-To: <20090624204106.GE28516@suse.de>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Wed, Jun 24, 2009 at 01:41:06PM -0700, Greg KH wrote:
> On Wed, Jun 24, 2009 at 08:31:16AM -0300, Thadeu Lima de Souza Cascardo wrote:
> > This commit 10077d4a6674f535abdbe25cdecb1202af7948f1 has stopped
>
> Please don't reference git commit ids that are not in Linus's tree, as
> it doesn't make any sense to anyone.
>
It is in Linus's tree. git log torvalds/master..10077d4 gives me
nothing.
cascardo@vespa:~/linux$ git remote show torvalds
* remote torvalds
URL:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git/
> > checking if there was a valid acm device associated to the tty, which is
> > not true right after open fails and tty subsystem tries to close the
> > device.
>
> Why would open fail?
>
Explained in a second version submitted already, but basically because
there's no such device.
> thanks,
>
> greg k-h
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-06-24 21:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 11:31 [PATCH 1/3] Return ENODEV instead of EINVAL when trying to open ACM device Thadeu Lima de Souza Cascardo
2009-06-24 11:31 ` [PATCH 2/3] Fix oops when closing ACM tty device right after open has failed Thadeu Lima de Souza Cascardo
2009-06-24 11:31 ` [PATCH 3/3] Fix oops when unexisting usb serial device is opened Thadeu Lima de Souza Cascardo
2009-06-24 20:41 ` Greg KH
2009-06-24 20:41 ` [PATCH 2/3] Fix oops when closing ACM tty device right after open has failed Greg KH
2009-06-24 21:35 ` Thadeu Lima de Souza Cascardo [this message]
2009-06-24 21:37 ` Greg KH
2009-06-24 20:40 ` [PATCH 1/3] Return ENODEV instead of EINVAL when trying to open ACM device Greg KH
2009-06-24 21:17 ` Oliver Neukum
2009-06-24 21:19 ` Thadeu Lima de Souza Cascardo
2009-06-24 21:33 Thadeu Lima de Souza Cascardo
2009-06-24 21:33 ` [PATCH 2/3] Fix oops when closing ACM tty device right after open has failed Thadeu Lima de Souza Cascardo
2009-06-24 21:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624213522.GH5299@vespa.holoscopio.com \
--to=cascardo@holoscopio.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®