mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: greg@kroah.com, hancockr@shaw.ca, alan@lxorguk.ukuu.org.uk,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	daniel.ritz@gmx.ch, linux@dominikbrodowski.net,
	kaneshige.kenji@jp.fujitsu.com, towerlexa@gmx.de,
	benh@kernel.crashing.org, mingo@elte.hu, tglx@linutronix.de,
	tony.luck@intel.com
Subject: Re: [RFC PATCH 1/2] pci: determine CLS more intelligently
Date: Thu, 25 Jun 2009 02:05:07 -0700 (PDT)	[thread overview]
Message-ID: <20090625.020507.203808859.davem@davemloft.net> (raw)
In-Reply-To: <4A43234D.9050608@kernel.org>

From: Tejun Heo <tj@kernel.org>
Date: Thu, 25 Jun 2009 16:12:13 +0900

> sparc64 is currently the only one using PCI_CACHE_LINE_BYTES.

Feel free to add the patch below and:

Acked-by: David S. Miller <davem@davemloft.net>

Although I think it's better to declare pci_dfl_cache_line_size in
linux/pci.h instead of making every arch do the extern decl.

diff --git a/arch/sparc/kernel/pci.c b/arch/sparc/kernel/pci.c
index 57859ad..511a592 100644
--- a/arch/sparc/kernel/pci.c
+++ b/arch/sparc/kernel/pci.c
@@ -1081,3 +1081,12 @@ void pci_resource_to_user(const struct pci_dev *pdev, int bar,
 	*start = rp->start - offset;
 	*end = rp->end - offset;
 }
+
+extern u8 pci_dfl_cache_line_size;
+
+static int __init pcibios_init(void)
+{
+	pci_dfl_cache_line_size = 64 >> 2;
+	return 0;
+}
+subsys_initcall(pcibios_init);

  parent reply	other threads:[~2009-06-25  9:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-25  7:12 Tejun Heo
2009-06-25  7:12 ` [RFC PATCH 2/2] pccard: configure CLS on attach Tejun Heo
2009-06-25  9:05 ` David Miller [this message]
2009-06-25 17:33   ` [RFC PATCH 1/2] pci: determine CLS more intelligently Greg KH
2009-06-30  3:07     ` Tejun Heo
2009-06-30 10:22       ` Benjamin Herrenschmidt
2009-06-25 10:07 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090625.020507.203808859.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=benh@kernel.crashing.org \
    --cc=daniel.ritz@gmx.ch \
    --cc=greg@kroah.com \
    --cc=hancockr@shaw.ca \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=towerlexa@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®