From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Mike Frysinger <vapier@gentoo.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_blk: add missing __dev{init,exit} markings
Date: Fri, 26 Jun 2009 12:37:36 -0700 [thread overview]
Message-ID: <20090626123736.594969c8@jbarnes-g45> (raw)
In-Reply-To: <200905200010.51786.rusty@rustcorp.com.au>
On Wed, 20 May 2009 00:10:51 +0930
Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Mon, 18 May 2009 05:09:09 pm Mike Frysinger wrote:
> > -static int virtblk_probe(struct virtio_device *vdev)
> > +static int __devinit virtblk_probe(struct virtio_device *vdev)
>
> This makes sense, I think, but then it implies that
> virtio_dev_probe() should also be __devinit, right?
>
> And I look at pci_bus_probe(), and it's not __devinit.
>
> Is the PCI code just slack?
I wouldn't be surprised if some annotations were missing or incorrect
given the churn in hotplug lately, but I can't find that particular
symbol...
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2009-06-26 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 7:39 Mike Frysinger
2009-05-19 14:40 ` Rusty Russell
2009-06-26 19:37 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090626123736.594969c8@jbarnes-g45 \
--to=jbarnes@virtuousgeek.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=vapier@gentoo.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome