mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 3/9] x86/moorestown: add moorestown platform flags
Date: Fri, 26 Jun 2009 14:34:46 +0100	[thread overview]
Message-ID: <20090626143446.2cf061f5@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20090626125111.GA11575@elte.hu>

> We will gladly take clean x86 patches that abstract away lowlevel 
> details of x86 platforms, and have been taking them and have been 
> writing them for a long time. If this patch-set can shape itself in 
> such a way (as i requested), without hindering the common case, it 
> is certainly welcome.

Lets try again shall we. I'l repeat the relevant bits of the mail you
quoted bits from and ignored almost all of

> The thing is, you are trying to defend a v1 patch-set here that is 
> really indefensible: it's ugly and deficient in numerous smaller and 
> larger details. I outlined numerous deficiencies already - and i'll 
> review v2 too to see what else is there to fix.  

No I'm trying to understand what you actually want the thing to look like.
Are we talking

/* Fixed struct not pointer for speed */
struct platform_ops platform_ops;
memcpy(platform_ops, platform_op_list[detect_platform_type()],
					sizeof(struct platform_ops));

platform->add_private_resources();
platform->timer_foo();
platfomr->timer_bar();

or

platform->init();
timer = platform->timer;

timer->begin()


  reply	other threads:[~2009-06-26 13:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-26  0:14 Pan, Jacob jun
2009-06-26  7:19 ` Ingo Molnar
2009-06-26  9:13   ` Alan Cox
2009-06-26  9:38     ` Ingo Molnar
2009-06-26 10:16       ` Alan Cox
2009-06-26 11:04         ` Ingo Molnar
2009-06-26 11:56           ` Alan Cox
2009-06-26 12:22             ` Ingo Molnar
2009-06-26 12:33               ` Alan Cox
2009-06-26 12:51                 ` Ingo Molnar
2009-06-26 13:34                   ` Alan Cox [this message]
2009-06-26 14:44                     ` Ingo Molnar
2009-06-26 14:29                 ` Ingo Molnar
2009-06-26 16:32                   ` Thomas Gleixner
2009-06-26 16:54                     ` Jesse Barnes
2009-06-30  6:35                       ` Pavel Machek
2009-07-01 17:25                         ` Jesse Barnes
2009-07-01 20:48                           ` Ingo Molnar
2009-06-26 15:00           ` Ingo Molnar
2009-06-26 16:51   ` Jesse Barnes
2009-06-26 18:45     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090626143446.2cf061f5@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=hpa@linux.intel.com \
    --cc=jacob.jun.pan@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®