From: David Miller <davem@davemloft.net>
To: alan@lxorguk.ukuu.org.uk
Cc: joe@perches.com, linux-kernel@vger.kernel.org,
trivial@kernel.org, akpm@linux-foundation.org,
Eng.Linux@digi.com
Subject: Re: [PATCH 14/62] drivers/char/epca.c: Remove unnecessary semicolons
Date: Sun, 28 Jun 2009 11:33:25 -0700 (PDT) [thread overview]
Message-ID: <20090628.113325.244931913.davem@davemloft.net> (raw)
In-Reply-To: <20090628185102.47663e61@lxorguk.ukuu.org.uk>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Sun, 28 Jun 2009 18:51:02 +0100
> On Sun, 28 Jun 2009 09:26:19 -0700
> Joe Perches <joe@perches.com> wrote:
>
>> Signed-off-by: Joe Perches <joe@perches.com>
>> ---
>> drivers/char/epca.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> If you must do this then please roll it into a single patch and get it
> applied so it doesn't mess up all the pending patches. Really though I
> have to ask what the point is - it just makes other patches not apply and
> creates noise work.
It has made bugs get added in the past, and makes code confusing
to read sometimes. I'm all for this, to be honest, and I'm very
much for rolling this into one single patch too :)
next prev parent reply other threads:[~2009-06-28 18:33 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-28 16:26 [PATCH 00/62] " Joe Perches
2009-06-28 16:26 ` [PATCH 01/62] arch/arm: " Joe Perches
2009-06-28 16:26 ` [PATCH 02/62] arch/ia64: " Joe Perches
2009-06-28 16:26 ` [PATCH 03/62] arch/m68knommu/kernel/time.c: " Joe Perches
2009-07-02 4:10 ` Greg Ungerer
2009-06-28 16:26 ` [PATCH 04/62] arch/mips/kernel/vpe.c: " Joe Perches
2009-06-28 17:53 ` Ralf Baechle
2009-06-28 16:26 ` [PATCH 05/62] arch/powerpc: " Joe Perches
2009-06-29 16:01 ` Geoff Levand
2009-06-28 16:26 ` [PATCH 06/62] arch/s390/hypfs/inode.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 07/62] arch/s390/kvm/interrupt.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 08/62] arch/sh/boards/mach-se/7206/io.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 09/62] arch/sparc/kernel/irq_64.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 10/62] arch/um/drivers/net_kern.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 11/62] arch/x86/kernel/ds.c: " Joe Perches
2009-06-28 16:40 ` Jaswinder Singh Rajput
2009-06-28 16:26 ` [PATCH 12/62] drivers/ata: " Joe Perches
2009-07-29 1:17 ` Jeff Garzik
2009-06-28 16:26 ` [PATCH 13/62] drivers/block: " Joe Perches
2009-06-28 16:26 ` [PATCH 14/62] drivers/char/epca.c: " Joe Perches
2009-06-28 17:51 ` Alan Cox
2009-06-28 18:33 ` David Miller [this message]
2009-06-28 18:44 ` [PATCH] " Joe Perches
2009-06-28 19:12 ` Pekka Enberg
2009-06-28 19:22 ` Joe Perches
2009-06-28 21:16 ` Jiri Kosina
2009-06-30 17:15 ` Joe Perches
2009-06-30 22:41 ` Jiri Kosina
2009-06-28 16:26 ` [PATCH 15/62] drivers/dma/fsldma.c: " Joe Perches
2009-07-02 0:27 ` Dan Williams
2009-06-28 16:26 ` [PATCH 16/62] drivers/dma: " Joe Perches
2009-06-28 16:26 ` [PATCH 17/62] drivers/gpu/drm: " Joe Perches
2009-06-28 16:26 ` [PATCH 18/62] drivers/hwmon/sht15.c: " Joe Perches
2009-06-28 19:01 ` [lm-sensors] " Jean Delvare
2009-06-28 16:26 ` [PATCH 19/62] drivers/ide: " Joe Perches
2009-06-28 16:26 ` [PATCH 20/62] drivers/isdn/capi/capiutil.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 21/62] drivers/macintosh/rack-meter.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 22/62] drivers/media/video/cx18/cx18-fileops.c: " Joe Perches
2009-06-28 17:17 ` Andy Walls
2009-06-28 17:21 ` Joe Perches
2009-06-28 18:10 ` Andy Walls
2009-06-28 18:16 ` [PATCH] MAINTAINERS: Remove ivtv-user lists, add CX18 url Joe Perches
2009-06-28 18:22 ` Andy Walls
2009-06-28 16:26 ` [PATCH 23/62] drivers/media/video/ivtv/ivtv-driver.c: Remove unnecessary semicolons Joe Perches
2009-06-28 16:26 ` [PATCH 24/62] drivers/media: " Joe Perches
2009-06-28 16:26 ` [PATCH 25/62] drivers/mfd/twl4030-irq.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 26/62] drivers/mmc/host/imxmmc.c: " Joe Perches
2009-07-01 9:26 ` Pavel Pisa
2009-07-31 9:30 ` Pierre Ossman
2009-08-02 22:34 ` Pavel Pisa
2009-06-28 16:26 ` [PATCH 27/62] drivers/net/wireless/ath/ath9k: " Joe Perches
2009-06-28 16:26 ` [PATCH 28/62] drivers/net/bnx2x_link.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 29/62] drivers/net/igb/igb_main.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 30/62] drivers/net/qlge/qlge_main.c: " Joe Perches
2009-06-28 18:35 ` [PATCH] MAINTAINERS: QLGE 10Gb ETHERNET - pair P:/M: entries properly Joe Perches
2009-06-28 18:40 ` David Miller
2009-06-28 16:26 ` [PATCH 31/62] drivers/net/skfp: Remove unnecessary semicolons Joe Perches
2009-06-28 16:26 ` [PATCH 32/62] drivers/net/skge.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 33/62] drivers/net/sky2.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 34/62] drivers/net: " Joe Perches
2009-06-28 16:26 ` [PATCH 35/62] drivers/pci/pcie/aer/ecrc.c: " Joe Perches
2009-06-29 18:15 ` Andrew Patterson
2009-06-29 19:21 ` Jesse Barnes
2009-06-28 16:26 ` [PATCH 36/62] drivers/pcmcia/pcmcia_resource.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 37/62] drivers/regulator/pcf50633-regulator.c: " Joe Perches
2009-06-29 10:32 ` Liam Girdwood
2009-06-28 16:26 ` [PATCH 38/62] drivers/rtc/rtc-omap.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 39/62] drivers/s390/block/dasd_eckd.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 40/62] drivers/s390/net/netiucv.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 41/62] drivers/s390/scsi/zfcp_scsi.c: " Joe Perches
2009-06-28 18:05 ` Christof Schmitt
2009-06-28 16:26 ` [PATCH 42/62] drivers/scsi/bnx2i/bnx2i_hwi.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 43/62] include/scsi/fc/fc_fc2.h: " Joe Perches
2009-06-28 16:26 ` [PATCH 44/62] drivers/scsi/lpfc/lpfc_ct.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 45/62] drivers/spi: " Joe Perches
2009-06-28 16:26 ` [PATCH 46/62] drivers/staging: " Joe Perches
2009-06-28 16:26 ` [PATCH 47/62] drivers/usb: " Joe Perches
2009-06-28 16:26 ` [PATCH 48/62] drivers/uwb/i1480/i1480u-wlp/netdev.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 49/62] drivers/video/cfbcopyarea.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 50/62] drivers/video/imxfb.c: " Joe Perches
2009-06-29 7:12 ` Sascha Hauer
2009-06-28 16:26 ` [PATCH 51/62] drivers/video/s3c2410fb.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 52/62] drivers/watchdog/bcm47xx_wdt.c: " Joe Perches
2009-06-29 18:05 ` Wim Van Sebroeck
2009-06-28 16:26 ` [PATCH 53/62] drivers/xen/balloon.c: " Joe Perches
2009-06-28 16:26 ` [PATCH 54/62] fs/autofs/dirhash.c: " Joe Perches
2009-06-28 16:27 ` [PATCH 55/62] fs/btrfs/tree-log.c: " Joe Perches
2009-06-28 16:27 ` [PATCH 56/62] fs/cifs/cifs_dfs_ref.c: " Joe Perches
2009-06-28 16:45 ` Steve French
2009-06-28 16:51 ` Joe Perches
2009-06-28 16:27 ` [PATCH 57/62] fs/ext4/mballoc.c: " Joe Perches
2009-07-06 2:34 ` Theodore Tso
2009-06-28 16:27 ` [PATCH 58/62] fs/nfs/callback_xdr.c: " Joe Perches
2009-06-28 16:27 ` [PATCH 59/62] fs/ocfs2/quota_global.c: " Joe Perches
2009-09-17 19:00 ` [Ocfs2-devel] " Mark Fasheh
2009-06-28 16:27 ` [PATCH 60/62] kernel/trace/trace_hw_branches.c: " Joe Perches
2009-06-28 16:27 ` [PATCH 61/62] net/wireless/wext-compat.c: " Joe Perches
2009-06-28 16:27 ` [PATCH 62/62] sound: " Joe Perches
2009-06-29 9:30 ` Mark Brown
2009-06-28 17:11 ` [PATCH 00/62] " Arjan van de Ven
2009-06-28 17:16 ` Joe Perches
2009-06-28 17:43 ` Arjan van de Ven
2009-06-28 17:48 ` Joe Perches
2009-06-28 18:32 ` David Miller
2009-06-28 18:45 ` Arjan van de Ven
2009-06-28 18:12 ` Andrew Morton
2009-06-29 9:48 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090628.113325.244931913.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Eng.Linux@digi.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®