mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Forest Bond <forest@alittletooquiet.net>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: "Greg KH" <greg@kroah.com>,
	"Larry Finger" <Larry.Finger@lwfinger.net>,
	"Alexander Beregalov" <a.beregalov@gmail.com>,
	"Woody Suwalski" <woodys@xandros.com>,
	"Gábor Stefanik" <netrolller.3d@gmail.com>,
	"Harald Welte" <HaraldWelte@viatech.com>,
	"Luis R. Rodriguez" <mcgrof@gmail.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: [PATCH 4/8] drivers/staging/vt6656/main_usb.c: Drop obsolete fsuid/fsgid accesses.
Date: Sun, 28 Jun 2009 13:03:07 -0400	[thread overview]
Message-ID: <20090628170307.GG9143@alittletooquiet.net> (raw)
In-Reply-To: <200906281759.46152.bzolnier@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]

[Greg: This patch series does not differ from that which you already have.]

drivers/staging/vt6656/main_usb.c: Drop obsolete fsuid/fsgid accesses.

Signed-off-by: Forest Bond <forest@alittletooquiet.net>
---
 drivers/staging/vt6656/main_usb.c |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 3368e83..f181d23 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -1655,15 +1655,17 @@ static UCHAR *Config_FileOperation(PSDevice pDevice) {
     UCHAR    *buffer=NULL;
     struct file   *filp=NULL;
     mm_segment_t old_fs = get_fs();
-    int oldfsuid=0,oldfsgid=0;
+    //int oldfsuid=0,oldfsgid=0;
     int result=0;
 
     set_fs (KERNEL_DS);
-//Make sure a caller can read or write power as root
-   oldfsuid=current->fsuid;
-   oldfsgid=current->fsgid;
+    /* Can't do this anymore, so we rely on correct filesystem permissions:
+    //Make sure a caller can read or write power as root
+    oldfsuid=current->fsuid;
+    oldfsgid=current->fsgid;
     current->fsuid = 0;
     current->fsgid = 0;
+    */
 
     //open file
       filp = filp_open(config_path, O_RDWR, 0);
@@ -1697,8 +1699,11 @@ error1:
 
 error2:
   set_fs (old_fs);
+
+  /*
   current->fsuid=oldfsuid;
   current->fsgid=oldfsgid;
+  */
 
 if(result!=0) {
     if(buffer)
-- 
1.5.6.3


-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2009-06-28 17:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09 10:31 Staging: vt6656 ? Alexander Beregalov
2009-06-09 10:51 ` Greg KH
2009-06-09 11:33   ` Forest Bond
2009-06-28 13:43     ` Bartlomiej Zolnierkiewicz
2009-06-28 13:57       ` Forest Bond
2009-06-28 15:59         ` Bartlomiej Zolnierkiewicz
2009-06-28 16:47           ` Forest Bond
2009-07-02 17:45             ` Bartlomiej Zolnierkiewicz
2009-07-02 18:22               ` Forest Bond
2009-07-06 15:33                 ` Bartlomiej Zolnierkiewicz
2009-06-28 17:02           ` [PATCH 1/8] Add pristine upstream vt6656 driver sources to drivers/staging/vt6656 Forest Bond
2009-06-28 17:02           ` [PATCH 2/8] Add includes " Forest Bond
2009-06-28 17:03           ` [PATCH 3/8] Build vt6656.ko, not vntwusb.ko Forest Bond
2009-06-28 17:03           ` Forest Bond [this message]
2009-06-28 17:03           ` [PATCH 5/8] vt6656: Replace net_device->priv accesses with netdev_priv calls Forest Bond
2009-06-28 17:03           ` [PATCH 6/8] vt6656: use net_device_ops for management functions Forest Bond
2009-06-28 17:03           ` [PATCH 7/8] vt6656: replace call to info with printk call Forest Bond
2009-06-28 17:03           ` [PATCH 8/8] Integrate drivers/staging/vt6656 into build system Forest Bond
2009-06-28 16:29         ` Staging: vt6656 ? Greg KH
2009-06-28 16:40           ` Forest Bond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090628170307.GG9143@alittletooquiet.net \
    --to=forest@alittletooquiet.net \
    --cc=HaraldWelte@viatech.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=a.beregalov@gmail.com \
    --cc=bzolnier@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    --cc=netrolller.3d@gmail.com \
    --cc=woodys@xandros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®