From: Wim Van Sebroeck <wim@iguana.be>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] watchdog: w83697ug, fix lock imbalance
Date: Mon, 29 Jun 2009 21:22:51 +0200 [thread overview]
Message-ID: <20090629192251.GI3982@infomag.iguana.be> (raw)
In-Reply-To: <1246291239-3331-1-git-send-email-jirislaby@gmail.com>
Hi Jiri,
Will add this to the linux-2.6-watchdog trees.
Kind regards,
Wim.
> Don't forget to unlock io_lock when w83697ug_select_wd_register fails in
> wdt_ctrl.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> ---
> drivers/watchdog/w83697ug_wdt.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/w83697ug_wdt.c b/drivers/watchdog/w83697ug_wdt.c
> index 883b5f7..a6c12de 100644
> --- a/drivers/watchdog/w83697ug_wdt.c
> +++ b/drivers/watchdog/w83697ug_wdt.c
> @@ -149,8 +149,10 @@ static void wdt_ctrl(int timeout)
> {
> spin_lock(&io_lock);
>
> - if (w83697ug_select_wd_register() < 0)
> + if (w83697ug_select_wd_register() < 0) {
> + spin_unlock(&io_lock);
> return;
> + }
>
> outb_p(0xF4, WDT_EFER); /* Select CRF4 */
> outb_p(timeout, WDT_EFDR); /* Write Timeout counter to CRF4 */
> --
> 1.6.3.2
>
prev parent reply other threads:[~2009-06-29 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 16:00 Jiri Slaby
2009-06-29 19:22 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629192251.GI3982@infomag.iguana.be \
--to=wim@iguana.be \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®