From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Andres Salomon <dilinger@collabora.co.uk>
Cc: cbou@mail.ru, dwmw2@infradead.org, linux-kernel@vger.kernel.org,
richard@laptop.org, Andrew Morton <akpm@linux-foundation.org>,
Paul Fox <pgf@laptop.org>,
dsaxena@laptop.org
Subject: Re: [PATCH 5/5] power_supply: add a charge_type status to the api, and use it for olpc driver
Date: Tue, 30 Jun 2009 12:31:35 +0100 [thread overview]
Message-ID: <20090630113135.GD13961@sirena.org.uk> (raw)
In-Reply-To: <20090630021730.44f86185@mycelium.queued.net>
On Tue, Jun 30, 2009 at 02:17:30AM -0400, Andres Salomon wrote:
> This adds a new sysfs file called 'charge_type' which displays the type of
> charging (n/a, trickle charge, slow charge, or fast charging). This allows
> things like battery diagnostics to determine what the battery/EC is doing
> without resorting to changing the 'status' sysfs output.
> Signed-off-by: Andres Salomon <dilinger@collabora.co.uk>
This looks good to me. Could you please keep me on the CC for any
future revisions of this patch, I can make use of this in the WM8350
driver.
> + static char *charge_type[] = {
> + "N/A", "Trickle", "Slow", "Fast"
> + };
I'd be tempted to make "N/A" be "Unknown" to match the style of the rest
of the attributes. I'm also not sure that we need a slow type, but
equally it shouldn't do any harm.
next prev parent reply other threads:[~2009-06-30 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 6:17 Andres Salomon
2009-06-30 11:31 ` Mark Brown [this message]
2009-06-30 15:04 ` Andres Salomon
2009-06-30 15:37 ` Anton Vorontsov
2009-06-30 15:57 ` Mark Brown
2009-06-30 19:02 ` Anton Vorontsov
2009-06-30 19:15 ` Mark Brown
2009-06-30 23:14 ` Anton Vorontsov
2009-07-02 13:45 ` Andres Salomon
2009-07-02 14:06 ` Mark Brown
2009-07-02 14:26 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630113135.GD13961@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=cbou@mail.ru \
--cc=dilinger@collabora.co.uk \
--cc=dsaxena@laptop.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pgf@laptop.org \
--cc=richard@laptop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®