From: Pavel Machek <pavel@ucw.cz>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, pierre@ossman.eu,
swetland@google.com, Andrew Morton <akpm@linux-foundation.org>,
San Mehat <san@google.com>
Subject: Re: [PATCH 0/3] msm_sdcc: A few more cleanups
Date: Tue, 30 Jun 2009 15:21:12 +0200 [thread overview]
Message-ID: <20090630132112.GB28447@elf.ucw.cz> (raw)
In-Reply-To: <1246365021.10129.146.camel@Joe-Laptop.home>
On Tue 2009-06-30 05:30:21, Joe Perches wrote:
> On Tue, 2009-06-30 at 08:57 +0200, Pavel Machek wrote:
> > diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
> > - do_div(clks, NSECS_PER_SEC);
> > + do_div(clks, NSEC_PER_SEC);
>
> Compiling is good. Submitting uncompiled patches not so good...
:-) Thanks for doing the cleanups. You know, fixing two compile
problems is easy compared to cleanups you did.
Can you fold those two fixups to your patches, or how to proceed?
> > @@ -588,6 +588,8 @@ static void
> > msmsdcc_handle_irq_data(struct msmsdcc_host *host, struct mmc_data *data,
> > u32 status)
> > {
> > + void __iomem *base = host->base;
> > +
>
> I don't know how performance sensitive this is.
>
> Maybe it should be inline and have base passed
> as an argument.
I don't think it is _that_ performance critical.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-06-30 13:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 21:41 MMC driver for HTC Dream Pavel Machek
2009-06-29 21:46 ` Brian Swetland
2009-06-29 22:16 ` Pavel Machek
2009-06-30 0:02 ` [PATCH 0/3] msm_sdcc: A few more cleanups Joe Perches
2009-06-30 0:02 ` [PATCH 1/3] msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>( Joe Perches
2009-06-30 0:02 ` [PATCH 2/3] msm_sdcc.c: stylistic cleaning Joe Perches
2009-06-30 0:02 ` [PATCH 3/3] msm_sdcc.c: Move overly indented code to separate function Joe Perches
2009-06-30 6:57 ` [PATCH 0/3] msm_sdcc: A few more cleanups Pavel Machek
2009-06-30 12:30 ` Joe Perches
2009-06-30 13:21 ` Pavel Machek [this message]
2009-06-30 15:31 ` [PATCH V2 0/3] msm_sdcc: cleanups Joe Perches
2009-06-30 15:31 ` [PATCH V2 1/3] msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>( Joe Perches
2009-06-30 15:31 ` [PATCH V2 2/3] msm_sdcc.c: stylistic cleaning Joe Perches
2009-06-30 15:31 ` [PATCH V2 3/3] msm_sdcc.c: Move overly indented code to separate function Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630132112.GB28447@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre@ossman.eu \
--cc=san@google.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®