mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Stefan Lippers-Hollmann <s.L-H@gmx.de>
Cc: linux-kernel@vger.kernel.org, ak@linux.intel.com, avi@redhat.com,
	ying.huang@intel.com, stable@kernel.org
Subject: Re: patch kvm-add-vt-x-machine-check-support.patch added to 2.6.30-stable tree
Date: Tue, 30 Jun 2009 16:42:06 -0700	[thread overview]
Message-ID: <20090630234206.GA22546@suse.de> (raw)
In-Reply-To: <200907010053.40900.s.L-H@gmx.de>

On Wed, Jul 01, 2009 at 12:53:37AM +0200, Stefan Lippers-Hollmann wrote:
> Hi
> 
> On Wednesday 01 July 2009, gregkh@suse.de wrote:
> > This is a note to let you know that we have just queued up the patch titled
> > 
> >     Subject: KVM: Add VT-x machine check support
> > 
> > to the 2.6.30-stable tree.  Its filename is
> > 
> >     kvm-add-vt-x-machine-check-support.patch
> > 
> > A git repo of this tree can be found at 
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > 
> > From a0861c02a981c943573478ea13b29b1fb958ee5b Mon Sep 17 00:00:00 2001
> > From: Andi Kleen <ak@linux.intel.com>
> > Date: Mon, 8 Jun 2009 17:37:09 +0800
> > Subject: KVM: Add VT-x machine check support
> 
> This patch fails to compile if applied to 2.6.30 + current stable queue.
> 
> arch/x86/kvm/vmx.c: In function 'vmx_vcpu_run':
> arch/x86/kvm/vmx.c:3573: error: 'exit_intr_info' undeclared (first use in this function)
> arch/x86/kvm/vmx.c:3573: error: (Each undeclared identifier is reported only once
> arch/x86/kvm/vmx.c:3573: error: for each function it appears in.)
> make[4]: *** [arch/x86/kvm/vmx.o] Error 1
> make[3]: *** [arch/x86/kvm] Error 2
> make[3]: *** Waiting for unfinished jobs....
> 
> It seems to depend on the code refactoring introduced by 
> 
> From 7b4a25cb296e2a73d2e87a4af65361d45d450a27 Mon Sep 17 00:00:00 2001
> From: Gleb Natapov <gleb@redhat.com>
> Date: Mon, 30 Mar 2009 16:03:08 +0300
> Subject: KVM: VMX: Fix handling of a fault during NMI unblocked due to IRET
> 
> Bit 12 is undefined in any of the following cases:
>  If the VM exit sets the valid bit in the IDT-vectoring information field.
>  If the VM exit is due to a double fault.
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> 
> and followed up by the code movement in
> 
> From 20f65983e30f222e5383f77206e3f571d1d64610 Mon Sep 17 00:00:00 2001
> From: Gleb Natapov <gleb@redhat.com>
> Date: Mon, 11 May 2009 13:35:55 +0300
> Subject: KVM: Move "exit due to NMI" handling into vmx_complete_interrupts()
> 
> To save us one reading of VM_EXIT_INTR_INFO.
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> Signed-off-by: Avi Kivity <avi@redhat.com>

Thanks, I was building without kvm enabled in my configs and missed this
one.

I've added these two other patches and everything looks better.

greg k-h

  reply	other threads:[~2009-06-30 23:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090629184144.76C9948FD3@coco.kroah.org>
2009-06-30 22:53 ` Stefan Lippers-Hollmann
2009-06-30 23:42   ` Greg KH [this message]
2009-07-01  7:09     ` Andi Kleen
2009-07-01  7:35       ` Avi Kivity
2009-07-01 13:24         ` Andi Kleen
2009-07-01 13:41           ` Avi Kivity
2009-07-01 14:18             ` Andi Kleen
2009-07-01 14:47               ` Avi Kivity
2009-07-01 14:58                 ` Greg KH
2009-07-01 15:04                   ` Avi Kivity
2009-07-01 17:27                     ` [stable] " Greg KH
2009-07-01 18:18                       ` Avi Kivity
2009-07-01 18:42                         ` Greg KH
2009-07-01 18:56                           ` Avi Kivity
2009-07-01 19:31                             ` Greg KH
2009-07-02 13:21                               ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090630234206.GA22546@suse.de \
    --to=gregkh@suse.de \
    --cc=ak@linux.intel.com \
    --cc=avi@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.L-H@gmx.de \
    --cc=stable@kernel.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome