From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761573AbZGAAjJ (ORCPT ); Tue, 30 Jun 2009 20:39:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760839AbZGAAci (ORCPT ); Tue, 30 Jun 2009 20:32:38 -0400 Received: from kroah.org ([198.145.64.141]:59726 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760865AbZGAAch (ORCPT ); Tue, 30 Jun 2009 20:32:37 -0400 X-Mailbox-Line: From gregkh@mini.kroah.org Tue Jun 30 17:15:48 2009 Message-Id: <20090701001548.420416552@mini.kroah.org> User-Agent: quilt/0.48-1 Date: Tue, 30 Jun 2009 17:13:59 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, "Peter Botha" , Jiri Slaby Subject: [patch 03/35] char: mxser, fix ISA board lookup References: <20090701001356.007288418@mini.kroah.org> Content-Disposition: inline; filename=char-mxser-fix-isa-board-lookup.patch In-Reply-To: <20090701002825.GA6518@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.29-stable review patch. If anyone has any objections, please let us know. ------------------ From: Peter Botha commit 96050dfb25966612008dcea7d342e91fa01e993c upstream. There's a bug in the mxser kernel module that still appears in the 2.6.29.4 kernel. mxser_get_ISA_conf takes a ioaddress as its first argument, by passing the not of the ioaddr, you're effectively passing 0 which means it won't be able to talk to an ISA card. I have tested this, and removing the ! fixes the problem. Cc: "Peter Botha" Signed-off-by: Jiri Slaby Acked-by: Alan Cox Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- drivers/char/mxser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/char/mxser.c +++ b/drivers/char/mxser.c @@ -2712,7 +2712,7 @@ static int __init mxser_module_init(void continue; brd = &mxser_boards[m]; - retval = mxser_get_ISA_conf(!ioaddr[b], brd); + retval = mxser_get_ISA_conf(ioaddr[b], brd); if (retval <= 0) { brd->info = NULL; continue;