From: Shaohua Li <shaohua.li@intel.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mel@csn.ul.ie" <mel@csn.ul.ie>,
"Zhao, Yakui" <yakui.zhao@intel.com>
Subject: Re: + memory-hotplug-alloc-page-from-other-node-in-memory-online.patch added to -mm tree
Date: Wed, 1 Jul 2009 10:55:58 +0800 [thread overview]
Message-ID: <20090701025558.GA28524@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <20090630004735.GA21254@sli10-desk.sh.intel.com>
On Tue, Jun 30, 2009 at 08:47:35AM +0800, Shaohua Li wrote:
> On Tue, Jun 30, 2009 at 06:07:16AM +0800, Christoph Lameter wrote:
> > On Mon, 29 Jun 2009, akpm@linux-foundation.org wrote:
> >
> > > To initialize hotadded node, some pages are allocated. At that time, the
> > > node hasn't memory, this makes the allocation always fail. In such case,
> > > let's allocate pages from other nodes.
> >
> > Thats bad. Could you populate the buddy list with some large pages from
> > the beginning of the node instead of doing this special casing? The
> > vmemmap and other stuff really should come from the node that is added.
> > Otherwise off node memory accesses will occur constantly for processors on
> > that node.
> Ok, this is preferred. But the node hasn't any memory present at that time,
> let me check how could we do it.
Hi Christoph,
Looks this is quite hard. Memory of the node isn't added into buddy. At that
time (sparse-vmmem init) buddy for the node isn't initialized and even page struct
for the hotadded memory isn't prepared too. We need something like bootmem
allocator to get memory ...
next prev parent reply other threads:[~2009-07-01 2:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200906291949.n5TJnuov028806@imap1.linux-foundation.org>
[not found] ` <alpine.DEB.1.10.0906291804340.21956@gentwo.org>
2009-06-30 0:47 ` Shaohua Li
2009-07-01 2:55 ` Shaohua Li [this message]
2009-07-01 3:39 ` yakui
2009-07-01 17:22 ` Christoph Lameter
2009-07-02 1:11 ` yakui
2009-07-02 1:22 ` KAMEZAWA Hiroyuki
2009-07-02 5:59 ` Yasunori Goto
2009-07-02 13:31 ` Christoph Lameter
2009-07-02 23:55 ` KAMEZAWA Hiroyuki
2009-07-03 9:12 ` Shaohua Li
2009-07-05 23:47 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090701025558.GA28524@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome