From: Jiri Olsa <jolsa@redhat.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, fbl@redhat.com, nhorman@redhat.com,
davem@redhat.com, htejun@gmail.com, jarkao2@gmail.com,
oleg@redhat.com, davidel@xmailserver.org, eric.dumazet@gmail.com
Subject: [PATCHv4 2/2] memory barrier: adding smp_mb__after_lock
Date: Thu, 2 Jul 2009 08:36:24 +0200 [thread overview]
Message-ID: <20090702063624.GC3429@jolsa.lab.eng.brq.redhat.com> (raw)
In-Reply-To: <20090702063259.GA3429@jolsa.lab.eng.brq.redhat.com>
Adding smp_mb__after_lock define to be used as a smp_mb call after
a lock.
Making it nop for x86, since {read|write|spin}_lock() on x86 are
full memory barriers.
wbr,
jirka
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
arch/x86/include/asm/spinlock.h | 3 +++
include/linux/spinlock.h | 5 +++++
include/net/sock.h | 2 +-
3 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/arch/x86/include/asm/spinlock.h b/arch/x86/include/asm/spinlock.h
index b7e5db8..39ecc5f 100644
--- a/arch/x86/include/asm/spinlock.h
+++ b/arch/x86/include/asm/spinlock.h
@@ -302,4 +302,7 @@ static inline void __raw_write_unlock(raw_rwlock_t *rw)
#define _raw_read_relax(lock) cpu_relax()
#define _raw_write_relax(lock) cpu_relax()
+/* The {read|write|spin}_lock() on x86 are full memory barriers. */
+#define smp_mb__after_lock() do { } while (0)
+
#endif /* _ASM_X86_SPINLOCK_H */
diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
index 252b245..ae053bd 100644
--- a/include/linux/spinlock.h
+++ b/include/linux/spinlock.h
@@ -132,6 +132,11 @@ do { \
#endif /*__raw_spin_is_contended*/
#endif
+/* The lock does not imply full memory barrier. */
+#ifndef smp_mb__after_lock
+#define smp_mb__after_lock() smp_mb()
+#endif
+
/**
* spin_unlock_wait - wait until the spinlock gets unlocked
* @lock: the spinlock in question.
diff --git a/include/net/sock.h b/include/net/sock.h
index 4eb8409..b3e96a4 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -1280,7 +1280,7 @@ static inline int sk_has_sleeper(struct sock *sk)
*
* This memory barrier is paired in the sock_poll_wait.
*/
- smp_mb();
+ smp_mb__after_lock();
return sk->sk_sleep && waitqueue_active(sk->sk_sleep);
}
next prev parent reply other threads:[~2009-07-02 6:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 6:32 [PATCHv4 0/2] net: fix race in the receive/select Jiri Olsa
2009-07-02 6:35 ` [PATCHv4 1/2] net: adding memory barrier to the poll and receive callbacks Jiri Olsa
2009-07-02 6:55 ` Eric Dumazet
2009-07-02 6:36 ` Jiri Olsa [this message]
2009-07-02 6:53 ` [PATCHv4 2/2] memory barrier: adding smp_mb__after_lock Eric Dumazet
2009-07-02 14:39 ` Davide Libenzi
2009-07-03 7:41 ` Jiri Olsa
2009-07-03 7:47 ` Jarek Poplawski
2009-07-03 7:51 ` Jiri Olsa
2009-07-03 7:50 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090702063624.GC3429@jolsa.lab.eng.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=davem@redhat.com \
--cc=davidel@xmailserver.org \
--cc=eric.dumazet@gmail.com \
--cc=fbl@redhat.com \
--cc=htejun@gmail.com \
--cc=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®