mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Kevin Winchester" <kjwinchester@gmail.com>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Paul Mackerras" <paulus@samba.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: tools/perf compile error: ignoring return value of 'read', declared with attribute warn_unused_result
Date: Thu, 2 Jul 2009 09:44:19 +0200	[thread overview]
Message-ID: <20090702074419.GB19187@elte.hu> (raw)
In-Reply-To: <4A4BF4A2.8030607@gmail.com>


* Kevin Winchester <kjwinchester@gmail.com> wrote:

>     CC builtin-stat.o
> cc1: warnings being treated as errors
> builtin-stat.c: In function 'run_perf_stat':
> builtin-stat.c:243: error: ignoring return value of 'read', declared with attribute warn_unused_result
> builtin-stat.c:256: error: ignoring return value of 'read', declared with attribute warn_unused_result
> make: *** [builtin-stat.o] Error 1
> 
> Apparently my version of gcc and/or glibc do not agree with -Werror.  Would the fix be as simple as:
> 
>     if *read(go_pipe[0], &buf, 1) < 0) {
>             perror("Failed to read go_pipe.");
>             exit(1);
>     }
> 
> ?

Yeah, that's Ubuntu doing some must-check-warnings via headers, 
right?

Frederic fixed a bug there yesterday - mind checking the latest 
perfcounters code at:

  http://people.redhat.com/mingo/tip.git/README

?

Thanks,

	Ingo

  reply	other threads:[~2009-07-02  7:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 23:43 Kevin Winchester
2009-07-02  7:44 ` Ingo Molnar [this message]
2009-07-02 23:49   ` Kevin Winchester

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090702074419.GB19187@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=kjwinchester@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®