mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josef Bacik <josef@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: npiggin@suse.de, stable@kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH] mm: mark page accessed before we write_end
Date: Thu, 2 Jul 2009 09:05:00 -0400	[thread overview]
Message-ID: <20090702130500.GF16713@dhcp231-156.rdu.redhat.com> (raw)

Hello,

In testing a backport of the write_begin/write_end AOPs, a 10% re-read
regression was noticed when running iozone.  This regression was introduced
because the old AOPs would always do a mark_page_accessed(page) after the
commit_write, but when the new AOPs where introduced, the only place this was
kept was in pagecache_write_end().  This patch does the same thing in the
generic case as what is done in pagecache_write_end(), which is just to mark
the page accessed before we do write_end().  Thank you,

Signed-off-by: Josef Bacik <jbacik@redhat.com>
---
 mm/filemap.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index 2239671..ccea3b6 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2272,6 +2272,7 @@ again:
 		pagefault_enable();
 		flush_dcache_page(page);
 
+		mark_page_accessed(page);
 		status = a_ops->write_end(file, mapping, pos, bytes, copied,
 						page, fsdata);
 		if (unlikely(status < 0))
-- 
1.5.4.3


             reply	other threads:[~2009-07-02 13:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-02 13:05 Josef Bacik [this message]
2009-07-02 13:46 ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090702130500.GF16713@dhcp231-156.rdu.redhat.com \
    --to=josef@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®