From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Doug Graham" <dgraham@nortel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: V3 minixfs bug
Date: Thu, 2 Jul 2009 22:27:04 +0100 [thread overview]
Message-ID: <20090702222704.15305c09@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4A4D2306.2000208@nortel.com>
On Thu, 02 Jul 2009 17:13:42 -0400
"Doug Graham" <dgraham@nortel.com> wrote:
> Is anybody interested in bugs in the minixfs V3 support that probably
> only turn up on big-endian machines, or on filesystems with more than
> 64K inodes?
If you've found them then yes.
> The problem is that that there are a few places (three that I've found)
> where the "inode" field of a minix_dir_entry is used without checking
> first to see if the dirent is really a minix3_dir_entry. The inode number
> in a V1/V2 dirent is 16 bits, whereas that in a V3 dirent is 32 bits.
> Accessing
> it as a 16 bit field when it really should be accessed as a 32 bit field
> probably kinda sorta works on a little-endian machine, but leads to some
> rather odd behaviour on big-endian machines.
>
> Here's a patch:
The one thing this needs for application is a Signed-off-by: line (see
Documentation/SubmittingPatches).
Alan
prev parent reply other threads:[~2009-07-02 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 21:13 Doug Graham
2009-07-02 21:27 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090702222704.15305c09@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=dgraham@nortel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®