From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759000AbZGCTOL (ORCPT ); Fri, 3 Jul 2009 15:14:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756831AbZGCTN5 (ORCPT ); Fri, 3 Jul 2009 15:13:57 -0400 Received: from zone0.gcu-squad.org ([212.85.147.21]:9413 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756264AbZGCTN5 (ORCPT ); Fri, 3 Jul 2009 15:13:57 -0400 Date: Fri, 3 Jul 2009 21:13:48 +0200 From: Jean Delvare To: Jonathan Cameron Cc: linux-kernel@vger.kernel.org, chrisv@cyberswitching.com, daniel@caiaq.de, iws@ovro.caltech.edu, dmitry.torokhov@gmail.com, hmh@hmh.eng.br, david-b@pacbell.net Subject: Re: [PATCH] IIO: Add missing I2C dependencies for max1363 and tsl2561 Message-ID: <20090703211348.4033c109@hyperion.delvare> In-Reply-To: <4A4E3BED.5050504@cam.ac.uk> References: <1246542464-6974-1-git-send-email-jic23@cam.ac.uk> <1246542464-6974-2-git-send-email-jic23@cam.ac.uk> <1246542464-6974-3-git-send-email-jic23@cam.ac.uk> <1246542464-6974-4-git-send-email-jic23@cam.ac.uk> <1246542464-6974-5-git-send-email-jic23@cam.ac.uk> <1246542464-6974-6-git-send-email-jic23@cam.ac.uk> <1246542464-6974-7-git-send-email-jic23@cam.ac.uk> <1246542464-6974-8-git-send-email-jic23@cam.ac.uk> <1246542464-6974-9-git-send-email-jic23@cam.ac.uk> <1246542464-6974-10-git-send-email-jic23@cam.ac.uk> <1246542464-6974-11-git-send-email-jic23@cam.ac.uk> <1246542464-6974-12-git-send-email-jic23@cam.ac.uk> <1246542464-6974-13-git-send-email-jic23@cam.ac.uk> <1246542464-6974-14-git-send-email-jic23@cam.ac.uk> <1246542464-6974-15-git-send-email-jic23@cam.ac.uk> <4A4E3BED.5050504@cam.ac.uk> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.4; i586-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 03 Jul 2009 17:12:13 +0000, Jonathan Cameron wrote: > Signed-off-by: Jonathan Cameron > > I will roll these into the original patches at some point, but > for now they are here. > > Thanks to David Brownell for spotting this. > --- > drivers/iio/adc/Kconfig | 2 +- > drivers/iio/light/Kconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index cb773d2..ab2066c 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -6,7 +6,7 @@ comment "Analog to digital convertors" > > config MAX1363 > tristate "MAXIM max1363 ADC driver" > - depends on IIO > + depends on IIO && I2C > help > Say yes here to build support for many MAXIM i2c analog to digital > convertors (ADC). (max1361, max1362, max1363, max1364, max1136, > diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig > index 620e249..62d502c 100644 > --- a/drivers/iio/light/Kconfig > +++ b/drivers/iio/light/Kconfig > @@ -6,7 +6,7 @@ comment "Light sensors" > > config TSL2561 > tristate "TAOS TSL2561 light-to-digital convertor" > - depends on IIO > + depends on IIO && I2C > help > Say yes bere to build support for the TAOS light to digital > convertor. This chip has two light sensors. One is broadband Unrelated suggestion: you could surround all the driver configuration entries with a big if IIO (...) endif # IIO This would save you the hassle of adding "depends on IIO" to every driver. Many subsystems have resorted to this technique by now. -- Jean Delvare