From: David Miller <davem@davemloft.net>
To: julia@diku.dk
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/net/cs89x0.c: Avoid using magic number in set_dma_mode
Date: Mon, 06 Jul 2009 19:10:11 -0700 (PDT) [thread overview]
Message-ID: <20090706.191011.38865597.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0907050922570.27464@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Sun, 5 Jul 2009 09:23:21 +0200 (CEST)
> The constant DMA_RX_MODE is defined to be 0x14 in the local include file
> cs89x0.h. Since a constant with the same name is used elsewhere with
> set_dma_mode, it seems likely that this constant could be used here.
>
> The semantic match that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied to net-next-2.6, thanks!
prev parent reply other threads:[~2009-07-07 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 7:23 Julia Lawall
2009-07-07 2:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090706.191011.38865597.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®