From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org, akpm@linux-foundation.org
Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
David Howells <dhowells@redhat.com>
Subject: [PATCH] AFS: Fix compilation warning
Date: Thu, 09 Jul 2009 10:44:30 +0100 [thread overview]
Message-ID: <20090709094430.23882.46013.stgit@warthog.procyon.org.uk> (raw)
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Fix the following warning:
fs/afs/dir.c: In function 'afs_d_revalidate':
fs/afs/dir.c:567: warning: 'fid.vnode' may be used uninitialized in this function
fs/afs/dir.c:567: warning: 'fid.unique' may be used uninitialized in this function
by marking the 'fid' variable as an uninitialized_var. The problem is that gcc
doesn't always manage to work out that fid is always set on the path through
the function that uses it.
Cc: linux-afs@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---
fs/afs/dir.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index 5272872..790ba9d 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -566,7 +566,7 @@ static struct dentry *afs_lookup(struct inode *dir, struct dentry *dentry,
static int afs_d_revalidate(struct dentry *dentry, struct nameidata *nd)
{
struct afs_vnode *vnode, *dir;
- struct afs_fid fid;
+ struct afs_fid uninitialized_var(fid);
struct dentry *parent;
struct key *key;
void *dir_version;
next reply other threads:[~2009-07-09 9:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 9:44 David Howells [this message]
2009-07-14 8:47 ` Jaswinder Singh Rajput
2009-07-14 8:58 ` Jaswinder Singh Rajput
2009-07-14 13:10 ` David Howells
2009-07-14 13:49 ` Jaswinder Singh Rajput
2009-07-14 14:16 ` David Howells
2009-07-14 16:17 ` David Howells
2009-07-14 16:36 ` Artem Bityutskiy
2009-07-14 17:22 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2009-07-09 8:04 [PATCH] AFS: fix " Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090709094430.23882.46013.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®