From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: "David Härdeman" <david@hardeman.nu>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-input@vger.kernel.org, jbarnes@virtuousgeek.org,
"Len Brown" <lenb@kernel.org>
Subject: [PATCH 0/2] Winbond driver as PNP
Date: Thu, 9 Jul 2009 15:38:21 -0600 [thread overview]
Message-ID: <200907091538.21685.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200907081052.20142.bjorn.helgaas@hp.com>
On Wednesday 08 July 2009 10:52:19 am Bjorn Helgaas wrote:
> On Wednesday 01 July 2009 02:20:59 am David Härdeman wrote:
> > On Wed, July 1, 2009 01:11, Bjorn Helgaas wrote:
> > > The winbond driver does not use any ACPI-specific functionality, so
> > > it might be simpler to write it as a PNP driver (which would depend
> > > on PNPACPI, of course).
> >
> > As far as I could tell from a quick look at include/linux/pnp.h, a
> > pnp_driver doesn't seem to have any .shutdown methods either, so I'm not
> > sure how it would help?
>
> PNPACPI parses the device resources for you, so you could get rid
> of the _CRS stuff in your driver.
>
> The only reason PNP and ACPI don't have .shutdown is because nobody
> has needed it yet. If you need it (and it sounds like you do), I
> think the cleanest thing would be to add it to PNP and turn your
> driver into a PNP driver.
Here are two sample patches to show you what I was suggesting. These
apply on top of the two Winbond patches currently in -mm.
next prev parent reply other threads:[~2009-07-09 21:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-27 5:18 [PATCH 0/2] Winbond IR driver David Härdeman
2009-06-27 5:18 ` [PATCH 1/2] ACPI: reintroduce acpi_device_ops .shutdown method David Härdeman
2009-06-30 21:10 ` Andrew Morton
2009-06-30 23:11 ` Bjorn Helgaas
2009-07-01 8:20 ` David Härdeman
2009-07-08 16:52 ` Bjorn Helgaas
2009-07-09 21:38 ` Bjorn Helgaas [this message]
2009-07-09 21:39 ` [PATCH 1/2] PNP: add " Bjorn Helgaas
2009-07-09 21:40 ` [PATCH 2/2] Winbond: convert from ACPI to PNP driver Bjorn Helgaas
2009-07-10 7:55 ` [PATCH 0/2] Winbond driver as PNP David Härdeman
2009-07-10 16:01 ` Bjorn Helgaas
2009-06-27 5:18 ` [PATCH 2/2] Add a driver for the Winbond WPCD376I IR functionality David Härdeman
2009-06-30 21:23 ` Andrew Morton
2009-07-01 7:47 ` David Härdeman
2009-07-01 18:06 ` Andrew Morton
2009-07-01 21:45 ` David Härdeman
2009-07-01 21:47 ` David Härdeman
2009-07-01 21:53 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907091538.21685.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=akpm@linux-foundation.org \
--cc=david@hardeman.nu \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®