From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sergey Senozhatsky <sergey.senozhatsky@mail.by>
Cc: Alan Cox <alan@linux.intel.com>, Alan Cox <alan@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: possible regression with pty.c commit
Date: Sat, 11 Jul 2009 23:24:52 +0100 [thread overview]
Message-ID: <20090711232452.4dc7c1ba@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20090711191556.GA3845@localdomain.by>
On Sat, 11 Jul 2009 22:15:56 +0300
Sergey Senozhatsky <sergey.senozhatsky@mail.by> wrote:
> Hello,
> commit d945cb9cce20ac7143c2de8d88b187f62db99bdc ("pty: Rework the pty layer to use the normal buffering logic")
> seems to brake kdesu.
This looks like a timing bug in kdesu at first glance but it may be more
complex.
> close(11) = 0
We close one side of the pty/tty pair
> write(10, "stop", 4) = 4
> write(10, "\n", 1) = 1
> fcntl64(10, F_GETFL) = 0x2 (flags O_RDWR)
> read(10, 0xbf840858, 255) = -1 EIO (Input/output error) <<<<<<<<<
At this point the other side is closed, we have a hangup and the read
correctly I think gets -EIO.
I will have a look at kdesu on Monday, I've got Fedora setups here so
hopefully I can reproduce it simply.
next prev parent reply other threads:[~2009-07-11 22:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-11 19:15 Sergey Senozhatsky
2009-07-11 22:24 ` Alan Cox [this message]
2009-07-11 23:55 ` Sergey Senozhatsky
2009-07-13 11:48 ` Alan Cox
2009-07-13 16:41 ` Sergey Senozhatsky
2009-07-14 16:28 ` Sergey Senozhatsky
2009-07-14 22:57 ` Pierre Willenbrock
2009-07-15 10:05 ` Alan Cox
2009-07-15 10:27 ` Sergey Senozhatsky
2009-07-15 10:30 ` Alan Cox
2009-07-15 17:03 ` Sergey Senozhatsky
2009-07-17 0:51 ` Dave Young
2009-07-17 8:34 ` Sergey Senozhatsky
2009-07-17 13:34 ` Dave Young
2009-07-19 23:07 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090711232452.4dc7c1ba@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@mail.by \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®