mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Yinghai Lu <yinghai@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86,apic - set cpu_has_apic for discrete apic
Date: Sun, 12 Jul 2009 09:52:00 +0400	[thread overview]
Message-ID: <20090712055200.GB4782@lenovo> (raw)
In-Reply-To: <alpine.LFD.2.00.0907120141020.13862@eddie.linux-mips.org>

[Maciej W. Rozycki - Sun, Jul 12, 2009 at 01:41:54AM +0100]
| On Sun, 12 Jul 2009, Cyrill Gorcunov wrote:
| 
| > In case of discrete apic (due to hardware or firmware reason)
| > cpuid may not retrieve cpu_has_apic bit. So for SMP
| > compiled kernels instead of long check we may set "fake"
| > cpu_has_apic bit and check only the bit in further code
| > flow.
| > 
| > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
| > ---
| > 
| > Please review carefully.
| 
|  Sure: how did you test it or plan to do so?
| 
|   Maciej
| 

  Well, I've been using code reading. No real hardware test.
I just don't have such a hardware.

  I've a two pretty old laptops will check today if they
are discrete apic based systems.

  Also I was thinking about spurious software tests --
ie to set discrete apic manually but actually I don't
think it will help.

  And also I hoped that Ingo has a hw farm even with
discrete apic maybe... :)

	-- Cyrill

  reply	other threads:[~2009-07-12  5:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-11 21:29 Cyrill Gorcunov
2009-07-12  0:41 ` Maciej W. Rozycki
2009-07-12  5:52   ` Cyrill Gorcunov [this message]
2009-07-12  6:31     ` Maciej W. Rozycki
2009-07-12  6:34       ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090712055200.GB4782@lenovo \
    --to=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®