mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jirislaby@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] NET: sungem, use spin_trylock_irqsave
Date: Tue, 14 Jul 2009 14:10:20 -0700 (PDT)	[thread overview]
Message-ID: <20090714.141020.34896663.davem@davemloft.net> (raw)
In-Reply-To: <1247520220-31960-2-git-send-email-jirislaby@gmail.com>

From: Jiri Slaby <jirislaby@gmail.com>
Date: Mon, 13 Jul 2009 23:23:40 +0200

> -	if (!spin_trylock(&gp->tx_lock)) {
> +	if (!spin_trylock_irqsave(&gp->tx_lock)) {

I'm about to give you a royal flaming.

Any idea why?

(hint: type 'make' before you send patches!!!!)


  parent reply	other threads:[~2009-07-14 21:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13 21:23 [PATCH 1/2] NET: phy_device, fix lock imbalance Jiri Slaby
2009-07-13 21:23 ` [PATCH 2/2] NET: sungem, use spin_trylock_irqsave Jiri Slaby
2009-07-14  2:12   ` David Miller
2009-07-14 21:10   ` David Miller [this message]
2009-07-14 21:18     ` Jiri Slaby
2009-07-14 19:27 ` [PATCH 1/2] NET: phy_device, fix lock imbalance David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090714.141020.34896663.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®