mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: petkovbb@googlemail.com
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] ide-tape: misc stuff
Date: Wed, 15 Jul 2009 11:16:06 -0700 (PDT)	[thread overview]
Message-ID: <20090715.111606.193724419.davem@davemloft.net> (raw)
In-Reply-To: <1247671100-8173-1-git-send-email-petkovbb@gmail.com>

From: Borislav Petkov <petkovbb@googlemail.com>
Date: Wed, 15 Jul 2009 17:18:16 +0200

> here is some ide-tape stuff.
> 
> * 0001: somehow fell through the cracks, DEBUG build fix

This is OK.

> * 0002: mostly code unification

I'm not applying this.  IDE is in deep maintainence mode and
we really need to avoid changes that don't fix real bugs and
have only marginal benefit, like this change.

> * 0003: this one converts ide-tape to the debugging scheme we use with ide-cd
>   and ide-floppy. It adds some debug calls at important places and has proven
>   very helpful when working on bug reports with users. No functional change.

I'm not applying this for the same reason as patch #2.

> * 0004: real bugfix

Ok, did you test this?

Please respin patch #1 and #4 as a two patch set and resubmit.

Thank you.

  parent reply	other threads:[~2009-07-15 18:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 15:18 Borislav Petkov
2009-07-15 15:18 ` [PATCH 1/4] ide-tape: fix debug call Borislav Petkov
2009-07-15 15:18 ` [PATCH 2/4] ide-tape: use PFX to all printks Borislav Petkov
2009-07-15 15:18 ` [PATCH 3/4] ide-tape: convert to ide_debug_log macro Borislav Petkov
2009-07-15 15:18 ` [PATCH 4/4] ide-tape: fix handling of postponed rqs Borislav Petkov
2009-07-15 18:16 ` David Miller [this message]
2009-07-15 18:43   ` [PATCH 0/4] ide-tape: misc stuff Borislav Petkov
2009-07-15 19:41     ` David Miller
2009-07-16  6:52       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090715.111606.193724419.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®