Re: [PATCH] Acerhdf: fix fan control for AOA150 model

[Borislav Petkov <petkovbb@googlemail.com>]

On Tue, Jul 14, 2009 at 09:07:08AM +0200, Peter Feuerer wrote:
> Hi Andrew,
> 
> Andrew Morton writes:
> 
> >On Sun, 12 Jul 2009 23:21:04 +0200
> >Peter Feuerer <peter@piie.net> wrote:
> …
> >>Changed:
> >> o Applied Borislav Petkov's patch (convert the fancmd[] array
> >>to a real    struct thus disambiguating command handling and
> >>making code more readable.)
> >> o Added BIOS product to BIOS table as AOA110 and AOA150 have
> >>   different register values
> >> o Added force_product parameter to allow forcing different
> >>   product
> >> o fixed linker warning caused by "acerhdf_drv" not being named
> >>   "acerhdf_driver"
> >>
> >>Signed-off-by: Peter Feuerer <peter@piie.net>
> >
> >It looks like this work should have been presented as four separate patches.
> 
> I'm not that familiar with git in general and sending patches yet.
> How do you do this in an effective way? Diffing all changes via git
> and then splitting up the "all-in-one-patch" to four smaller patches
> manually?

Here's a very fine reading how to do stuff with git:

http://www.kernel.org/pub/software/scm/git/docs/user-manual.html
 
> >Inclusion of Borislav's Signed-off-by: would be appropriate.
> 
> I wasn't sure whether I'm allowed to send the patch with his
> signed-off, as there were other things in the patch, he didn't
> review. But next time I'll send such a patch splitted up and then
> it's clear.

Normally, one S-O-B in a multi-S-O-B patch refers only to the bits that
single author has changed. In case you want to say that only a subset of
the changes are originating from one person, you can mention that in the
commit message, something along the lines of

"... patch based loosely on work by... " or similar.

By the way, your patch works fine here:

Acked-by: Borislav Petkov <petkovbb@gmail.com>

-- 
Regards/Gruss,
    Boris.