mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Alan Cox <alan@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Hans de Goede <hdegoede@redhat.com>
Subject: Re: Why do we probe option roms at 2K boundaries?
Date: Thu, 16 Jul 2009 00:10:16 +0100	[thread overview]
Message-ID: <20090716001016.489fa970@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1247698965.3989.1.camel@dwillia2-linux.ch.intel.com>

> interrogating a data structure stored in option-rom memory.  My initial
> implementation involved blindly scanning from c0000 to f0000 in 512 byte
> increments.  Neil and others pointed out that this may not be a safe

It isn't safe. If you hit certain ISA devices your system will drop dead.
OTOH I doubt anyone has an intel matrix raid controller and a WD80x3 on
the same box ;)

> Recently Hans has been working to get Fedora up and running on a recent
> Intel software RAID platform and noticed that the option-rom is no
> longer visible with the 2K aligned scan.  I.e. he needed to make the
> following changes to the mdadm probe_roms() routine:

Option ROMs should be 2K aligned. Is your data structure part of a ROM or
an actual ROM header ?

> Is this safe?  Should the kernel be updated as well?  I am assuming that
> you were the one that originally introduced the 2K aligned scan with
> this commit from the historical git:

Actually I don't think that was me, don't remember it anyway.

The man to bug at the moment on ROM magic is probably H Peter Anvin
however.


  reply	other threads:[~2009-07-15 23:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15 23:02 Dan Williams
2009-07-15 23:10 ` Alan Cox [this message]
2009-07-15 23:13   ` Jon Smirl
2009-07-16  0:08     ` Dan Williams
2009-07-16  7:24       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090716001016.489fa970@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=alan@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®