From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755432AbZGPEiZ (ORCPT ); Thu, 16 Jul 2009 00:38:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752677AbZGPEiY (ORCPT ); Thu, 16 Jul 2009 00:38:24 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:46669 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665AbZGPEiX (ORCPT ); Thu, 16 Jul 2009 00:38:23 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Andrew Morton Subject: Re: [PATCH 1/3] Rename pgmoved variable in shrink_active_list() Cc: kosaki.motohiro@jp.fujitsu.com, LKML , linux-mm , Wu Fengguang , Rik van Riel , Minchan Kim , Christoph Lameter In-Reply-To: <20090715213516.9b47ad16.akpm@linux-foundation.org> References: <20090716131928.9D25.A69D9226@jp.fujitsu.com> <20090715213516.9b47ad16.akpm@linux-foundation.org> Message-Id: <20090716133622.9D34.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Thu, 16 Jul 2009 13:38:21 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Thu, 16 Jul 2009 13:22:30 +0900 (JST) KOSAKI Motohiro wrote: > > > -#define __add_zone_page_state(__z, __i, __d) \ > > - __mod_zone_page_state(__z, __i, __d) > > -#define __sub_zone_page_state(__z, __i, __d) \ > > - __mod_zone_page_state(__z, __i,-(__d)) > > - > > yeah, whatever, I don't think they add a lot of value personally. > > I guess they're a _bit_ clearer than doing __sub_zone_page_state() with > a negated argument. Shrug. OK, I've catched your point. I'll make all caller replacing patches. Thanks.