From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, fengguang.wu@intel.com,
minchan.kim@gmail.com, riel@redhat.com
Subject: Re: + mm-vmstat-add-isolate-pages.patch added to -mm tree
Date: Thu, 16 Jul 2009 14:34:54 +0900 (JST) [thread overview]
Message-ID: <20090716143311.9D3A.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20090716142903.0c7f8a92.kamezawa.hiroyu@jp.fujitsu.com>
> On Wed, 15 Jul 2009 20:21:36 -0700
> akpm@linux-foundation.org wrote:
> > ------------------------------------------------------
> > Subject: mm: vmstat: add isolate pages
> > From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> >
>
> Hi, Kosaki,
>
> > If the system is running a heavy load of processes then concurrent reclaim
> > can isolate a large number of pages from the LRU. /proc/meminfo and the
> > output generated for an OOM do not show how many pages were isolated.
> >
> <snip>
>
> > @@ -742,6 +746,13 @@ int migrate_pages(struct list_head *from
> > struct page *page2;
> > int swapwrite = current->flags & PF_SWAPWRITE;
> > int rc;
> > + int flags;
>
> unsigned long.
Grr. yes my fault.
> > +
> > + local_irq_save(flags);
> > + list_for_each_entry(page, from, lru)
> > + __inc_zone_page_state(page, NR_ISOLATED_ANON +
> > + !!page_is_file_cache(page));
> > + local_irq_restore(flags);
Fixing patch is here ;-)
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/mm/migrate.c
===================================================================
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -744,7 +744,7 @@ int migrate_pages(struct list_head *from
struct page *page2;
int swapwrite = current->flags & PF_SWAPWRITE;
int rc;
- int flags;
+ unsigned long flags;
local_irq_save(flags);
list_for_each_entry(page, from, lru)
prev parent reply other threads:[~2009-07-16 5:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200907160321.n6G3LaFZ028244@imap1.linux-foundation.org>
2009-07-16 5:29 ` KAMEZAWA Hiroyuki
2009-07-16 5:34 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090716143311.9D3A.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®