mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Gregory Haskins <ghaskins@novell.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	avi@redhat.com, glommer@redhat.com, aliguori@us.ibm.com
Subject: Re: [KVM PATCH] KVM: introduce "xinterface" API for external interaction with guests
Date: Thu, 16 Jul 2009 17:30:19 +0200	[thread overview]
Message-ID: <20090716153019.GA5727@merkur.ravnborg.org> (raw)
In-Reply-To: <20090716151945.29318.10882.stgit@dev.haskins.net>

> diff --git a/arch/x86/Kbuild b/arch/x86/Kbuild
> index ad8ec35..9f50cc3 100644
> --- a/arch/x86/Kbuild
> +++ b/arch/x86/Kbuild
> @@ -1,5 +1,7 @@
>  
> -obj-$(CONFIG_KVM) += kvm/
> +ifdef CONFIG_KVM
> +obj-y += kvm/
> +endif

What was wrong with the old version?
If this is because xinterface.o is builtin to the kernel then we should
always visit kvm/ and use:

   obj-y += kvm/

unconditionally.



>  
>  # Xen paravirtualization support
>  obj-$(CONFIG_XEN) += xen/
> diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
> index afaaa76..80d951d 100644
> --- a/arch/x86/kvm/Makefile
> +++ b/arch/x86/kvm/Makefile
> @@ -17,3 +17,7 @@ kvm-amd-y		+= svm.o
>  obj-$(CONFIG_KVM)	+= kvm.o
>  obj-$(CONFIG_KVM_INTEL)	+= kvm-intel.o
>  obj-$(CONFIG_KVM_AMD)	+= kvm-amd.o
> +
> +ifdef CONFIG_KVM
> +obj-y += $(addprefix ../../../virt/kvm/, xinterface.o)
> +endif
And when we always visit kvm/ the above code snippet makes sense.
Before we never visited kvm/ unless CONFIG_KVM was defined.

	Sam

  reply	other threads:[~2009-07-16 15:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16 15:19 [KVM PATCH] xinterface Gregory Haskins
2009-07-16 15:19 ` [KVM PATCH] KVM: introduce "xinterface" API for external interaction with guests Gregory Haskins
2009-07-16 15:30   ` Sam Ravnborg [this message]
2009-07-16 15:31     ` Gregory Haskins
2009-07-16 15:37   ` Anthony Liguori
2009-07-16 15:47     ` Gregory Haskins
2009-07-16 16:09       ` Anthony Liguori
2009-07-16 16:52   ` Arnd Bergmann
2009-07-16 18:22     ` Gregory Haskins
2009-07-16 18:53       ` Gregory Haskins
2009-07-16 19:38         ` Zan Lynx
2009-07-16 19:48           ` Gregory Haskins
2009-07-16 19:46       ` Arnd Bergmann
2009-07-17  0:25         ` Gregory Haskins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090716153019.GA5727@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=ghaskins@novell.com \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®