From: Jiri Olsa <jolsa@redhat.com>
To: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] tracing: dont reset set_ftrace_filter/notrace when opened with r/w perm
Date: Thu, 16 Jul 2009 18:51:35 +0200 [thread overview]
Message-ID: <20090716165135.GA4739@jolsa.lab.eng.brq.redhat.com> (raw)
If user setup set_ftrace_filter/set_ftrace_notrace files and then opens them
with read&write permissions, the previous setup will be removed.
Tested with following program:
[snip]
#include <stdio.h>
#include <string.h>
int main(int argc, char **argv)
{
FILE *f;
char *mode = "w+";
char *file = argv[1];
if (argc == 3)
mode = argv[2];
if (NULL == (f = fopen(file, mode))) {
perror("fopen failed");
return -1;
}
while(!feof(f)) {
#define BUFLEN 100
char buf[BUFLEN];
memset(buf, 0, BUFLEN);
fgets(buf, BUFLEN, f);
printf(buf);
}
fclose(f);
return 0;
}
[snip]
wbr,
jirka
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 4521c77..11394bc 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -1661,10 +1661,6 @@ ftrace_regex_open(struct inode *inode, struct file *file, int enable)
return -ENOMEM;
mutex_lock(&ftrace_regex_lock);
- if ((file->f_mode & FMODE_WRITE) &&
- !(file->f_flags & O_APPEND))
- ftrace_filter_reset(enable);
-
if (file->f_mode & FMODE_READ) {
iter->pg = ftrace_pages_start;
iter->flags = enable ? FTRACE_ITER_FILTER :
@@ -2260,6 +2256,9 @@ ftrace_regex_write(struct file *file, const char __user *ubuf,
return 0;
mutex_lock(&ftrace_regex_lock);
+ if ((file->f_mode & FMODE_WRITE) &&
+ !(file->f_flags & O_APPEND))
+ ftrace_filter_reset(enable);
if (file->f_mode & FMODE_READ) {
struct seq_file *m = file->private_data;
next reply other threads:[~2009-07-16 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 16:51 Jiri Olsa [this message]
2009-07-17 9:37 ` Li Zefan
2009-07-17 11:10 ` Jiri Olsa
2009-07-20 0:55 ` Li Zefan
2009-07-20 1:32 ` Frederic Weisbecker
2009-07-22 12:19 ` Jiri Olsa
2009-07-21 1:11 ` Steven Rostedt
2009-07-22 7:42 ` Jiri Olsa
2009-07-22 15:19 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090716165135.GA4739@jolsa.lab.eng.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®