mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: reinette chatre <reinette.chatre@intel.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	Trivial patch monkey <trivial@kernel.org>
Subject: iwl3945: fix LED config option
Date: Sat, 18 Jul 2009 12:20:31 +0200	[thread overview]
Message-ID: <20090718102030.GA2040@elf.ucw.cz> (raw)
In-Reply-To: <1247153986.17896.1233.camel@rc-desk>

On Thu 2009-07-09 08:39:46, reinette chatre wrote:
> On Thu, 2009-07-09 at 02:38 -0700, Pavel Machek wrote:
> > > > 
> > > > (Also wifi LED stopped working on x60, but that's older issue).
> > > 
> > > Is there a bug report for this?
> > 
> > Well... I thought that was known issue?
> > 
> > Anyway, wifi LED used to work on x60 before driver rewrite. Now it is
> > broken. I thought it is known/missing functionality? ...but I'd like
> > to get it back :-).
> 
> Sorry ... but I have to ask ... did you compile with
> CONFIG_IWLWIFI_LEDS ? If you still have issues - please do submit a bug
> report.

Aha, this explains it:

  Enable LED support in iwlagn and iwl3945 drivers (IWLWIFI_LEDS) [N/y] (NEW) ?

Sorry, no help available for this option yet.

...maybe LEDS should be default Y?
									Pavel

---

IWLWIFI_LEDS option should certainly have help comment, and should
default to y. Actually I wonder if it should be user configurable at
all, is there good reason?

Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
index e092af0..95d9aa5 100644
--- a/drivers/net/wireless/iwlwifi/Kconfig
+++ b/drivers/net/wireless/iwlwifi/Kconfig
@@ -9,6 +9,10 @@ config IWLWIFI
 config IWLWIFI_LEDS
 	bool "Enable LED support in iwlagn and iwl3945 drivers"
 	depends on IWLWIFI
+	default y
+	---help---
+	  Useful to get Wifi LED working at least on Thinkpad notebooks.
+
 
 config IWLWIFI_SPECTRUM_MEASUREMENT
 	bool "Enable Spectrum Measurement in iwlagn driver"


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2009-07-18 10:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19 22:24 iwl3945 in 2.6.31-rc0: ad-hoc mode broken? Pavel Machek
2009-06-22 17:39 ` reinette chatre
2009-06-22 17:40   ` Pavel Machek
2009-06-22 18:01     ` reinette chatre
2009-06-29 18:08 ` reinette chatre
     [not found]   ` <20090709093859.GA10001@elf.ucw.cz>
     [not found]     ` <1247153986.17896.1233.camel@rc-desk>
2009-07-18 10:20       ` Pavel Machek [this message]
2009-07-20 20:45         ` iwl3945: fix LED config option reinette chatre
2009-07-20 22:19           ` Pavel Machek
2009-07-21  3:02             ` reinette chatre
2009-07-21  7:58               ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090718102030.GA2040@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®