From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alan Jenkins <sourcejedi.lkml@googlemail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC/RFT] serio - switch to using dev_pm_ops
Date: Wed, 22 Jul 2009 09:38:33 -0700 [thread overview]
Message-ID: <20090722163832.GB2775@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <9b2b86520907211448t24a091e2i6d8ad89f709f35ff@mail.gmail.com>
On Tue, Jul 21, 2009 at 10:48:05PM +0100, Alan Jenkins wrote:
> > drivers/input/serio/serio.c | 30 ++++++++++++++++--------------
> > 1 files changed, 16 insertions(+), 14 deletions(-)
>
> > - if (!serio->suspended && state.event == PM_EVENT_SUSPEND)
> > - serio_cleanup(serio);
> > -
> > - serio->suspended = state.event == PM_EVENT_SUSPEND ||
> > - state.event == PM_EVENT_FREEZE;
>
> > - if (serio->suspended) {
> > - serio->suspended = false;
> > - serio_queue_event(serio, NULL, SERIO_RECONNECT_PORT);
> > - }
>
> It looks like you should be able to remove the suspended field of
> struct serio. Or is it used somewhere else?
>
No, it is not needed now, thanks for noticing.
--
Dmitry
prev parent reply other threads:[~2009-07-22 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 8:06 Dmitry Torokhov
2009-07-21 21:48 ` Alan Jenkins
2009-07-22 16:38 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090722163832.GB2775@dtor-d630.eng.vmware.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sourcejedi.lkml@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®