mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: Jiri Slaby <jirislaby@gmail.com>,
	Parag Warudkar <parag.warudkar@gmail.com>,
	linux-kernel@vger.kernel.org, sds@tycho.nsa.gov,
	jmorris@namei.org, eparis@parisplace.org
Subject: Re: 2.6.31-rc2: BUG: unable to handle kernel NULL pointer dereference
Date: Wed, 22 Jul 2009 22:28:17 +0200	[thread overview]
Message-ID: <200907222228.18615.rjw@sisk.pl> (raw)
In-Reply-To: <1248117834.7185.17.camel@localhost>

On Monday 20 July 2009, Thomas Meyer wrote:
> Am Sonntag, den 12.07.2009, 22:26 +0200 schrieb Jiri Slaby:
> > On 07/12/2009 07:30 PM, Parag Warudkar wrote:
> > > static void selinux_write_opts(struct seq_file *m,
> > > 1012                                struct security_mnt_opts *opts)
> > > 1013 {
> > > 1014         int i;
> > > 1015         char *prefix;
> > > 1016
> > > 1017         for (i = 0; i < opts->num_mnt_opts; i++) {
> > > 1018                 char *has_comma;
> > > 1019
> > > 1020                 if (opts->mnt_opts[i])
> > > 1021                         has_comma = strchr(opts->mnt_opts[i], ',');
> > >                                          ^^^^^^^^^^^^^^^^^^^^^^^^^
> > > And that is a NULL pointer dereference - but we just checked for
> > > opts->mnt_opts[i] for not NULL. 
> > 
> > Note, that there is not a NULL dereference. It dereferences 0x40 which
> > came in as %rdi. Looks like somebody assigned garbage in there.
> > 
> > Or a single bit mem error. Is memtest OK with this machine?
> Yes it ran fine for one cycle (about 2:15 hours).
> 
> Maybe memory in acpi S3 is not so stable? Is this possible?

Generally, it is, but I haven't seen it happen yet.  In theory, if the memory
chips are not refreshed appropriately while suspended, something like this may
happen.

Best,
Rafael

  reply	other threads:[~2009-07-22 20:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-12 14:47 Thomas Meyer
2009-07-12 17:30 ` Parag Warudkar
2009-07-12 20:26   ` Jiri Slaby
2009-07-12 21:54     ` Parag Warudkar
2009-07-12 21:56     ` Eric Paris
2009-07-13 17:00     ` Thomas Meyer
2009-07-13 17:45       ` Jiri Slaby
2009-07-20 19:23     ` Thomas Meyer
2009-07-22 20:28       ` Rafael J. Wysocki [this message]
2009-07-24 11:03         ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907222228.18615.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=eparis@parisplace.org \
    --cc=jirislaby@gmail.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=parag.warudkar@gmail.com \
    --cc=sds@tycho.nsa.gov \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome