From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275AbZGWOFS (ORCPT ); Thu, 23 Jul 2009 10:05:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751736AbZGWOFQ (ORCPT ); Thu, 23 Jul 2009 10:05:16 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:61793 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976AbZGWOFQ (ORCPT ); Thu, 23 Jul 2009 10:05:16 -0400 Message-Id: <20090723140514.198935904@goodmis.org> References: <20090723140259.100790900@goodmis.org> User-Agent: quilt/0.46-1 Date: Thu, 23 Jul 2009 10:03:00 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Andrew Morton , Li Zefan , Frederic Weisbecker , Thomas Gleixner Subject: [PATCH 1/3] trace_stack: Fix seqfile memory leak Content-Disposition: inline; filename=0001-trace_stack-Fix-seqfile-memory-leak.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Li Zefan Every time we cat stack_trace, we leak memory allocated by seq_open(). Signed-off-by: Li Zefan LKML-Reference: <4A67D8E8.3020500@cn.fujitsu.com> Signed-off-by: Steven Rostedt --- kernel/trace/trace_stack.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c index e644af9..6a2a9d4 100644 --- a/kernel/trace/trace_stack.c +++ b/kernel/trace/trace_stack.c @@ -301,17 +301,14 @@ static const struct seq_operations stack_trace_seq_ops = { static int stack_trace_open(struct inode *inode, struct file *file) { - int ret; - - ret = seq_open(file, &stack_trace_seq_ops); - - return ret; + return seq_open(file, &stack_trace_seq_ops); } static const struct file_operations stack_trace_fops = { .open = stack_trace_open, .read = seq_read, .llseek = seq_lseek, + .release = seq_release, }; int -- 1.6.3.3 --