mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] mfd: Allow multiple MFD cells with the same name
Date: Sat, 25 Jul 2009 12:23:59 +0100	[thread overview]
Message-ID: <20090725112359.GB4600@sirena.org.uk> (raw)
In-Reply-To: <20090724223554.GA10055@sortiz.org>

On Sat, Jul 25, 2009 at 12:35:55AM +0200, Samuel Ortiz wrote:
> On Mon, Jul 13, 2009 at 12:30:18PM +0100, Mark Brown wrote:

> > Samuel, do you have any thoughts on this patch?  As I said...

> I think it's safe to expect people that decide they need this feature will be
> careful enough to make sure they dont get ID collisions.

Yes, and it should be fairly easy to work out what's gone wrong if there
are any problems.

> > ...but it'd be really helpful to get some idea if this approach is going
> > to be viable for some code I'm currently working on.

> I'm ok with this patch, but I'd like the new cell->id field to be more
> documented. In particular we should mention that one should leave it to 0
> unless trying to add several cells of the same type.
> I'll push this patch once I'll be back from vacation, thanks.

OK, thanks.  I'm not sure when you're back from your vacation but early
next week I should be releasing the code which I was mentioning above -
if you've not applied it before then I'll try to include a revised
version with more documentation in that series.

      reply	other threads:[~2009-07-25 11:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-02 16:06 Mark Brown
2009-07-13 11:30 ` Mark Brown
2009-07-24 22:35   ` Samuel Ortiz
2009-07-25 11:23     ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090725112359.GB4600@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®