From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: linux-kernel@vger.kernel.org
Subject: slqb enables interrupts very early
Date: Sat, 25 Jul 2009 20:03:21 +0200 [thread overview]
Message-ID: <20090725180321.GA24814@Chamillionaire.breakpoint.cc> (raw)
I've checkout slab-2.6/linux-next and noticed that the interrupts are
enabled very early by accident. Please look at the following call stack:
start_kernel()
kmem_cache_init()
kmem_cache_open()
down_write(&slqb_lock);
__down_write()
__down_write_nested()
Now, __down_write_nested() protects its internal structure the follwing
way:
spin_lock_irq(&sem->wait_lock);
...
spin_unlock_irq(&sem->wait_lock);
so once we return, we return with interrupts on.
Sebastian
next reply other threads:[~2009-07-25 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-25 18:03 Sebastian Andrzej Siewior [this message]
2009-07-27 7:39 ` Pekka Enberg
2009-07-29 6:58 ` Nick Piggin
2009-07-29 11:02 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090725180321.GA24814@Chamillionaire.breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®