mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Nicolas Palix <npalix@diku.dk>
Cc: hjanssen@microsoft.com, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Staging: hv: Transform typedef HANDLE into void *
Date: Mon, 27 Jul 2009 12:20:30 -0700	[thread overview]
Message-ID: <20090727192030.GA4201@suse.de> (raw)
In-Reply-To: <200907272111.35259.npalix@diku.dk>

On Mon, Jul 27, 2009 at 09:11:34PM +0200, Nicolas Palix wrote:
> 
> Remove typedef HANDLE which aliases a void pointer and use void *
> anywhere HANDLE was used.

No, I would like to change this to be the "real" pointer that the HANDLE
was used for, instead of just a void pointer.  These need to point to
real structures.  I did this already for the locks, and can be done for
pretty much everything else as well.

> -int WorkQueueQueueWorkItem(HANDLE hWorkQueue, PFN_WORKITEM_CALLBACK workItem, void* context)
> +int WorkQueueQueueWorkItem(void *hWorkQueue, PFN_WORKITEM_CALLBACK workItem, void *context)
>  {
>  	WORKQUEUE *wq = (WORKQUEUE *)hWorkQueue;

Here's an example.  This should really be a pointer to a "work queue"
and not a void pointer at all.  Changes like that would be gladly
accepted.

thanks,

greg k-h

      reply	other threads:[~2009-07-27 19:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-27 19:11 Nicolas Palix
2009-07-27 19:20 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090727192030.GA4201@suse.de \
    --to=gregkh@suse.de \
    --cc=hjanssen@microsoft.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npalix@diku.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®