From: Pavel Machek <pavel@ucw.cz>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Zhaolei <zhaolei@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] Add function to convert between calendar time and broken-down time for universal use
Date: Tue, 28 Jul 2009 00:44:32 +0200 [thread overview]
Message-ID: <20090727224432.GB7142@elf.ucw.cz> (raw)
In-Reply-To: <87ocr9mi8h.fsf@devron.myhome.or.jp>
On Sat 2009-07-25 14:42:06, OGAWA Hirofumi wrote:
> Zhaolei <zhaolei@cn.fujitsu.com> writes:
>
> > +/*
> > + * Similar to the struct tm in userspace <time.h>, but it needs to be here so
> > + * that the kernel source is self contained.
> > + */
> > +struct tm {
> > + /*
> > + * the number of seconds after the minute, normally in the range
> > + * 0 to 59, but can be up to 60 to allow for leap seconds
> > + */
> > + int tm_sec;
> > + /* the number of minutes after the hour, in the range 0 to 59*/
> > + int tm_min;
> > + /* the number of hours past midnight, in the range 0 to 23 */
> > + int tm_hour;
> > + /* the day of the month, in the range 1 to 31 */
> > + int tm_mday;
> > + /* the number of months since January, in the range 0 to 11 */
> > + int tm_mon;
> > + /* the number of years since 1900 */
> > + int tm_year;
>
> Why isn't this "long"? "int" can overflow.
Overflow? Year?
I'm not sure how far ahead you are looking, but support for year
2000000000 (2e9) seems perfectly okay to me. (Our friendly star here,
sun, is going to die at cca year 5e9, for comparison. )
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-07-27 22:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 8:03 [PATCH " Zhaolei
2009-07-14 8:04 ` [PATCH 2/2] fs/fat: Use common localtime/gmtime in fat_time_unix2fat() Zhaolei
2009-07-14 22:10 ` [PATCH 1/2] Add function to convert between calendar time and broken-down time for universal use Andrew Morton
2009-07-15 0:59 ` Zhaolei
2009-07-15 7:23 ` [PATCH v2 0/2] " Zhaolei
2009-07-15 7:24 ` [PATCH v2 1/2] " Zhaolei
2009-07-15 7:25 ` [PATCH v2 2/2] Use common localtime/gmtime in fat_time_unix2fat() Zhaolei
2009-07-18 11:50 ` [PATCH 1/2] Add function to convert between calendar time and broken-down time for universal use Pavel Machek
2009-07-20 2:56 ` [PATCH 1/2] Add function to convert between calendar time andbroken-down " Zhaolei
2009-07-20 3:20 ` Andrew Morton
2009-07-20 9:55 ` [PATCH v3 0/2] Add function to convert between calendar time and broken-down " Zhaolei
2009-07-20 9:56 ` [PATCH v3 1/2] " Zhaolei
2009-07-25 5:42 ` OGAWA Hirofumi
2009-07-25 8:50 ` OGAWA Hirofumi
2009-07-25 12:15 ` OGAWA Hirofumi
2009-07-27 3:15 ` Zhaolei
2009-07-27 6:04 ` OGAWA Hirofumi
2009-07-28 3:05 ` Zhaolei
2009-07-28 5:12 ` OGAWA Hirofumi
2009-07-30 5:39 ` [PATCH v4 0/2] " Zhaolei
2009-07-30 5:40 ` [PATCH v4 1/2] " Zhaolei
2009-07-30 5:41 ` [PATCH v4 2/2] Use common time_to_tm in fat_time_unix2fat() Zhaolei
2009-07-27 22:44 ` Pavel Machek [this message]
2009-07-28 4:52 ` [PATCH v3 1/2] Add function to convert between calendar time and broken-down time for universal use OGAWA Hirofumi
2009-07-20 9:57 ` [PATCH v3 2/2] Use common localtime/gmtime in fat_time_unix2fat() Zhaolei
2009-07-20 10:03 ` Pavel Machek
2009-07-25 5:43 ` OGAWA Hirofumi
2009-07-27 3:21 ` Zhaolei
2009-07-18 10:02 ` [PATCH 1/2] Add function to convert between calendar time and broken-down time for universal use Ingo Molnar
2009-07-18 12:10 ` H. Peter Anvin
2009-07-18 12:41 ` Ulrich Drepper
2009-07-18 12:26 ` Andi Kleen
2009-07-20 2:41 ` Zhaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090727224432.GB7142@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®