From: "J. Bruce Fields" <bfields@fieldses.org>
To: Daniel J Blueman <daniel.blueman@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-nfs@vger.kernel.org, Benny Halevy <bhalevy@panasas.com>
Subject: Re: [2.6.31-rc4] nfs4 writecount warning...
Date: Tue, 28 Jul 2009 12:18:14 -0400 [thread overview]
Message-ID: <20090728161813.GG19497@fieldses.org> (raw)
In-Reply-To: <6278d2220907271449l38609680n943875d2672da20f@mail.gmail.com>
On Mon, Jul 27, 2009 at 10:49:03PM +0100, Daniel J Blueman wrote:
> After two days uptime on my NFS4 server with 2.6.31-rc4 and a few
> 2.6.28 clients, I hit the file write-count
> WARN_ON(f->f_mnt_write_state != 0) in file_take_write() in the
> nfsd4_open path [1].
Hm, so probably introduced by:
e518f0560a191269bd345178c899c790eb1ad4c8 "nfsd: take file and mnt write
in nfs4_upgrade_open".
The other possible file_take_write() caller here is dentry_open (which
calls it in the (f->f_mode & FMODE_WRITE) case).
Looks like nfs4_upgrade_open() isn't handling error case cleanup
correctly. Perhaps that could explain this.
--b.
>
> I can't find this reported elsewhere; let me know if it's preferred in
> bugzilla.kernel.org etc.
>
> Thanks,
> Daniel
>
> --- [1]
>
> ------------[ cut here ]------------
>
> WARNING: at include/linux/fs.h:953 nfsd4_process_open2+0x9c3/0xc90()
>
> Hardware name: OEM
>
> Modules linked in: coretemp w83627ehf hwmon_vid ath9k
> snd_hda_codec_realtek mac80211 led_class ath snd_hda_intel
> snd_hda_codec snd_pcm snd_timer snd pl2303 soundcore snd_page_alloc
>
> Pid: 2970, comm: nfsd Tainted: G W 2.6.31-rc4-274sd #1
>
> Call Trace:
>
> [<ffffffff81190413>] ? nfsd4_process_open2+0x9c3/0xc90
>
> [<ffffffff810490f8>] warn_slowpath_common+0x78/0xd0
>
> [<ffffffff8104915f>] warn_slowpath_null+0xf/0x20
>
> [<ffffffff81190413>] nfsd4_process_open2+0x9c3/0xc90
>
> [<ffffffff8118420f>] ? do_open_lookup+0x28f/0x300
>
> [<ffffffff811844b9>] nfsd4_open+0x239/0x420
>
> [<ffffffff81183c67>] nfsd4_proc_compound+0x2d7/0x530
>
> [<ffffffff81172115>] nfsd_dispatch+0x115/0x260
>
> [<ffffffff813f3d12>] svc_process+0x492/0x800
>
> [<ffffffff8142e507>] ? down_read+0x77/0x80
>
> [<ffffffff81172740>] ? nfsd+0x0/0x160
>
> [<ffffffff8117281d>] nfsd+0xdd/0x160
>
> [<ffffffff81062c9e>] kthread+0x9e/0xb0
>
> [<ffffffff8100ce9a>] child_rip+0xa/0x20
>
> [<ffffffff8100c83c>] ? restore_args+0x0/0x30
>
> [<ffffffff81062c00>] ? kthread+0x0/0xb0
>
> [<ffffffff8100ce90>] ? child_rip+0x0/0x20
>
> ---[ end trace 8ecb5c2eb0ae54d8 ]---
>
> --
> Daniel J Blueman
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-07-28 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 21:49 Daniel J Blueman
2009-07-28 16:18 ` J. Bruce Fields [this message]
2009-07-28 18:15 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090728161813.GG19497@fieldses.org \
--to=bfields@fieldses.org \
--cc=bhalevy@panasas.com \
--cc=daniel.blueman@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®