Re: [rtc-linux] [PATCH 7/9] drivers/rtc: correct error-handling code

[Wolfram Sang <w.sang@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

On Tue, Jul 28, 2009 at 05:55:33PM +0200, Julia Lawall wrote:
> 
> From: Julia Lawall <julia@diku.dk>
> 
> This code is not executed before ds1307->rtc has been successfully
> initialized to the result of calling rtc_device_register.  Thus the test
> that ds1307->rtc is not NULL is always true.
> 
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @match exists@
> expression x, E;
> statement S1, S2;
> @@
> 
> x = rtc_device_register(...)
> ... when != x = E
> (
> *  if (x == NULL || ...) S1 else S2
> |
> *  if (x == NULL && ...) S1 else S2
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@diku.dk>

Acked-by: Wolfram Sang <w.sang@pengutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]