From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932122AbZG1XJC (ORCPT ); Tue, 28 Jul 2009 19:09:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752869AbZG1XIu (ORCPT ); Tue, 28 Jul 2009 19:08:50 -0400 Received: from kroah.org ([198.145.64.141]:42965 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755583AbZG1XD4 (ORCPT ); Tue, 28 Jul 2009 19:03:56 -0400 X-Mailbox-Line: From gregkh@mini.kroah.org Tue Jul 28 15:59:43 2009 Message-Id: <20090728225943.151650963@mini.kroah.org> User-Agent: quilt/0.48-1 Date: Tue, 28 Jul 2009 15:58:43 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, WANG Cong , Alexander Viro , David Howells , Roland McGrath , James Morris Subject: [patch 15/37] elf: fix one check-after-use References: <20090728225828.431071451@mini.kroah.org> Content-Disposition: inline; filename=elf-fix-one-check-after-use.patch In-Reply-To: <20090728230145.GA10486@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.27-stable review patch. If anyone has any objections, please let us know. ------------------ From: Amerigo Wang commit e2dbe12557d85d81f4527879499f55681c3cca4f upstream. Check before use it. Signed-off-by: WANG Cong Cc: Alexander Viro Cc: David Howells Acked-by: Roland McGrath Acked-by: James Morris Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- fs/binfmt_elf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1517,11 +1517,11 @@ static int fill_note_info(struct elfhdr info->thread = NULL; psinfo = kmalloc(sizeof(*psinfo), GFP_KERNEL); - fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo); - if (psinfo == NULL) return 0; + fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo); + /* * Figure out how many notes we're going to need for each thread. */