Re: [PATCH] staging/android/lowmemorykiller: fix module param errors

[Randy Dunlap <rdunlap@xenotime.net>]

On Fri, 31 Jul 2009 14:14:57 -0400 (EDT) Robert P. J. Day wrote:

> On Fri, 31 Jul 2009, Randy Dunlap wrote:
> 
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Move module_params to near the end of the source file so that
> > their references are already known/defined.  Fixes build errors:
> >
> > drivers/staging/android/lowmemorykiller.c: In function '__check_cost':
> > drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared (first use in this function)
> > drivers/staging/android/lowmemorykiller.c: At top level:
> > drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared here (not in a function)
> > drivers/staging/android/lowmemorykiller.c:60: warning: type defaults to 'int' in declaration of 'type name'
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > ---
> >  drivers/staging/android/lowmemorykiller.c |   14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > --- linux-next-20090731.orig/drivers/staging/android/lowmemorykiller.c
> > +++ linux-next-20090731/drivers/staging/android/lowmemorykiller.c
> > @@ -57,13 +57,6 @@ static int lowmem_minfree_size = 4;
> >  			printk(x);			\
> >  	} while (0)
> >
> > -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> > -module_param_array_named(adj, lowmem_adj, int, &lowmem_adj_size,
> > -			 S_IRUGO | S_IWUSR);
> > -module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
> > -			 S_IRUGO | S_IWUSR);
> > -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
> > -
> >  static int lowmem_shrink(int nr_to_scan, gfp_t gfp_mask)
> >  {
> >  	struct task_struct *p;
> > @@ -166,6 +159,13 @@ static void __exit lowmem_exit(void)
> >  	unregister_shrinker(&lowmem_shrinker);
> >  }
> >
> > +module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> > +module_param_array_named(adj, lowmem_adj, int, &lowmem_adj_size,
> > +			 S_IRUGO | S_IWUSR);
> > +module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
> > +			 S_IRUGO | S_IWUSR);
> > +module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
> > +
> >  module_init(lowmem_init);
> >  module_exit(lowmem_exit);
> 
>   isn't that a bit non-standard?  from what i've seen, the standard
> seems to be to define something as a module parameter *immediately*
> after its definition, not to collect them all at the bottom of the
> source file separate from the definitions.  *is* there a standard for
> that?

not that i know of.  and we generally prefer to avoid forward declarations
just to satisfy such errors.

---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/