From: Randy Dunlap <randy.dunlap@oracle.com>
To: akpm@linux-foundation.org, "David Härdeman" <david@hardeman.nu>
Cc: linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH -mmotm] input/winbond-cir: select BITREVERSE
Date: Fri, 31 Jul 2009 14:45:50 -0700 [thread overview]
Message-ID: <20090731144550.c0861733.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200907301204.n6UC4Saf019612@imap1.linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
winbond-cir driver uses bitreverse functions so it needs to
select BITREVERSE to fix these build errors:
drivers/built-in.o: In function `wbcir_shutdown':
winbond-cir.c:(.text+0x104fc7): undefined reference to `byte_rev_table'
winbond-cir.c:(.text+0x104fd8): undefined reference to `byte_rev_table'
winbond-cir.c:(.text+0x104ff4): undefined reference to `byte_rev_table'
drivers/built-in.o: In function `wbcir_irq_handler':
winbond-cir.c:(.text+0x105f47): undefined reference to `byte_rev_table'
winbond-cir.c:(.text+0x105f5f): undefined reference to `byte_rev_table'
drivers/built-in.o:winbond-cir.c:(.text+0x105f77): more undefined references to `byte_rev_table' follow
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: David Härdeman <david@hardeman.nu>
---
drivers/input/misc/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- mmotm-2009-0730-0501.orig/drivers/input/misc/Kconfig
+++ mmotm-2009-0730-0501/drivers/input/misc/Kconfig
@@ -226,6 +226,7 @@ config INPUT_WINBOND_CIR
tristate "Winbond IR remote control"
depends on X86 && ACPI
select LEDS_CLASS
+ select BITREVERSE
help
Say Y here if you want to use the IR remote functionality found
in some Winbond SuperI/O chips. Currently only the WPCD376I
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
next prev parent reply other threads:[~2009-07-31 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 12:04 mmotm 2009-07-30-05-01 uploaded akpm
2009-07-31 21:34 ` mmotm 2009-07-30-05-01 uploaded (proc page monitor) Randy Dunlap
2009-07-31 21:45 ` Randy Dunlap [this message]
2009-08-04 3:12 ` mmotm 2009-07-30-05-01 uploaded KAMEZAWA Hiroyuki
2009-08-04 6:42 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090731144550.c0861733.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@hardeman.nu \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®